status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-19 04:46:48 +00:00
Code Issues Projects Releases Wiki Activity

Pass data prop instead of props to _updateViewableItems in _onScroll

Browse Source 
Summary:
This is a simple bugfix. `_updateViewableItems` expects the `data` prop, as it calls `getItemCount` on it. Without this, `onViewableItemsChanged` updates twice for each scroll position, once from `_onScroll` with the incorrect results, and once from `_updateCellsToRender` with the correct results. This means the callback nigh-on unusable.

I simply logged the results of `onViewableItemsChanged` and made sure they were correct.
Closes https://github.com/facebook/react-native/pull/14162

Differential Revision: D5128363

Pulled By: sahrens

fbshipit-source-id: 3faef812068921a26ed871339da79870fd0d911c
This commit is contained in:
ashoat 2017-05-25 03:12:04 -07:00 committed by Facebook Github Bot
parent e9ae31dfd6
commit 803a9168f2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/Lists/VirtualizedList.js
View File

@ -734,7 +734,7 @@ class VirtualizedList extends React.PureComponent<OptionalProps, Props, State> {
const dOffset = offset - this._scrollMetrics.offset;
const velocity = dOffset / dt;
this._scrollMetrics = {contentLength, dt, dOffset, offset, timestamp, velocity, visibleLength};
this._updateViewableItems(this.props);
this._updateViewableItems(this.props.data);
if (!this.props) {
return;
}