status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixes type definition of StackFrame 

Summary:
**Motivation**
This PR fixes the flow type definition of StackFrame in parseErrorStack.js. The methodName was missing and the column could be `null`. We integrate with it in our codebase and we wanted to use `methodName`, but flow complained.

Refer to this file for possible values: [github.com/errwischt/stacktrace-parser/blob/master/lib/stacktrace-parser.js](https://github.com/errwischt/stacktrace-parser/blob/master/lib/stacktrace-parser.js)

This also allowed me to remove a flow error suppression.

**Test plan (required)**
I ran flow on the project, no errors
Closes https://github.com/facebook/react-native/pull/12499

Differential Revision: D4619885

Pulled By: ericvicenti

fbshipit-source-id: 0bf5a2304cb0dc9f2c6df026a5cee71c8a419c01
This commit is contained in:
Wietse Venema 2017-02-27 02:33:49 -08:00 committed by Facebook Github Bot
parent 27928f3993
commit 800dc77172
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/Core/Devtools/parseErrorStack.js
View File

@ -12,9 +12,10 @@
'use strict'; 'use strict';
export type StackFrame = { export type StackFrame = {
column: ?number,
file: string, file: string,
lineNumber: number, lineNumber: number,
column: number, methodName: string,
}; };
var stacktraceParser = require('stacktrace-parser'); var stacktraceParser = require('stacktrace-parser');

2
Libraries/Core/Timers/JSTimers.js
View File

@ -40,8 +40,6 @@ function _allocateCallback(func: Function, type: JSTimerType): number {
e.framesToPop = 1; e.framesToPop = 1;
const stack = parseErrorStack(e); const stack = parseErrorStack(e);
if (stack) { if (stack) {
/* $FlowFixMe(>=0.32.0) - this seems to be putting something of the wrong
* type into identifiers */
JSTimersExecution.identifiers[freeIndex] = stack.shift(); JSTimersExecution.identifiers[freeIndex] = stack.shift();
} }
} }