status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

"this" not needed in mReactInstanceManager.onDestroy() 

Summary:
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**

Explain the **motivation** for making this change. What existing problem does the pull request solve?

Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

**Test plan (required)**

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Make sure tests pass on both Travis and Circle CI.

**Code formatting**

Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide).

For more info, see
Closes https://github.com/facebook/react-native/pull/10924

Differential Revision: D4181397

Pulled By: ericvicenti

fbshipit-source-id: e5c762937efba3bd65fbe00cc94678e8c1461659
This commit is contained in:
Liam 2016-11-14 20:55:56 -08:00 committed by Facebook Github Bot
parent 31b7819b02
commit 7f6d435188
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/IntegrationWithExistingApps.md
View File

@ -693,7 +693,7 @@ protected void onDestroy() {
super.onDestroy(); super.onDestroy();
if (mReactInstanceManager != null) { if (mReactInstanceManager != null) {
mReactInstanceManager.onDestroy(this); mReactInstanceManager.onDestroy();
} }
} }
``` ```