From 7e2e0deeb05a1a290bf24322bb9aef0acb1481a3 Mon Sep 17 00:00:00 2001 From: Simon Ayzman Date: Thu, 28 Jul 2016 12:39:41 -0700 Subject: [PATCH] Updated ScrollView's keyboardShouldPersistTaps doc Summary: I noticed that even when a ScrollView's `keyboardShouldPersistTaps` prop is set to true, the ScrollView's children can still respond to tap events (even if the scroll view itself will not respond to tap events and the keyboard does not dismiss automatically). This is a point of ambiguity in the React Native docs; it implies that no touch events can be handled if `keyboardShouldPersistTaps` is set to true. Closes https://github.com/facebook/react-native/pull/9053 Differential Revision: D3636711 Pulled By: hramos fbshipit-source-id: 2f0aea86202ab66d5a9174ce8611509dff67e15f --- Libraries/Components/ScrollView/ScrollView.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/Components/ScrollView/ScrollView.js b/Libraries/Components/ScrollView/ScrollView.js index 8c0746205..f96b2d93a 100644 --- a/Libraries/Components/ScrollView/ScrollView.js +++ b/Libraries/Components/ScrollView/ScrollView.js @@ -178,9 +178,9 @@ const ScrollView = React.createClass({ ]), /** * When false, tapping outside of the focused text input when the keyboard - * is up dismisses the keyboard. When true, the scroll view will not catch - * taps, and the keyboard will not dismiss automatically. The default value - * is false. + * is up dismisses the keyboard. When true, the keyboard will not dismiss + * automatically, and the scroll view will not catch taps, but children of + * the scroll view can catch taps. The default value is false. */ keyboardShouldPersistTaps: PropTypes.bool, /**