status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-21 13:48:13 +00:00
Code Issues Projects Releases Wiki Activity

Quote "$NODE_BINARY" in react-native-xcode.sh (#21383)

Browse Source 
Summary:
Fix build errors when path to $NODE_BINARY contains spaces:

error: Can't find '/Path/With Spaces/To/node' binary to build React Native bundle

Why would $NODE_BINARY contain spaces? In my case, I am using sentry-cli which wraps the NODE_BINARY in it's own executable. The local path to the project, and thus the $NODE_BINARY, contains a space on my GoCD build agent.

'/Users/go/Library/Application Support/Go Agent/pipelines/my-ios-app/node_modules/sentry/cli/sentry-cli

See https://github.com/getsentry/react-native-sentry/issues/484 https://github.com/getsentry/react-native-sentry/issues/389
Pull Request resolved: https://github.com/facebook/react-native/pull/21383

Differential Revision: D10851141

Pulled By: yungsters

fbshipit-source-id: f46853ac8b57957864e0d1a76b8513403223fccb
This commit is contained in:
Ryan Sundberg 2018-10-25 00:50:16 -07:00 committed by Facebook Github Bot
parent 99632e16d9
commit 7d4e94edcc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/react-native-xcode.sh
View File

@ -102,11 +102,11 @@ nodejs_not_found()
exit 2
}
type $NODE_BINARY >/dev/null 2>&1 || nodejs_not_found
type "$NODE_BINARY" >/dev/null 2>&1 || nodejs_not_found
BUNDLE_FILE="$DEST/main.jsbundle"
$NODE_BINARY "$CLI_PATH" $BUNDLE_COMMAND \
"$NODE_BINARY" "$CLI_PATH" $BUNDLE_COMMAND \
$CONFIG_ARG \
--entry-file "$ENTRY_FILE" \
--platform ios \