status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

[ReactNative] backout orange box 

Summary:
@public

This probably needs more thought - might want to differentiate between console.error and reportError.

Test Plan: console.error and reportError no longer redbox.  invariant and RCTLogError still do.
This commit is contained in:
Spencer Ahrens 2015-06-11 10:39:52 -07:00
parent 34f317695c
commit 7b7e0bf881
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
React/Base/RCTLog.m
View File

@ -171,9 +171,6 @@ void _RCTLogFormat(
// Log to red box // Log to red box
if (level >= RCTLOG_REDBOX_LEVEL) { if (level >= RCTLOG_REDBOX_LEVEL) {
if (level < RCTLOG_FATAL_LEVEL) {
[[RCTRedBox sharedInstance] setNextBackgroundColor:[UIColor colorWithRed:0.9 green:0.4 blue:0.2 alpha:1]];
}
[[RCTRedBox sharedInstance] showErrorMessage:message]; [[RCTRedBox sharedInstance] showErrorMessage:message];
} }

4
React/Modules/RCTExceptionsManager.m
View File

@ -44,9 +44,7 @@ RCT_EXPORT_METHOD(reportSoftException:(NSString *)message
[_delegate handleSoftJSExceptionWithMessage:message stack:stack]; [_delegate handleSoftJSExceptionWithMessage:message stack:stack];
return; return;
} }
RCTRedBox *box = [RCTRedBox sharedInstance]; [[RCTRedBox sharedInstance] showErrorMessage:message withStack:stack];
[box setNextBackgroundColor:[UIColor colorWithRed:0.9 green:0.4 blue:0.2 alpha:1]];
[box showErrorMessage:message withStack:stack];
} }
RCT_EXPORT_METHOD(reportFatalException:(NSString *)message RCT_EXPORT_METHOD(reportFatalException:(NSString *)message