status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fabric: Making some picky compilers happy 

Summary: Trivial nits.

Reviewed By: mdvacca

Differential Revision: D12897927

fbshipit-source-id: 61cec4a070218606d52f05740aacbfae1d2efd31
This commit is contained in:
Valentin Shergin 2018-11-06 10:58:51 -08:00 committed by Facebook Github Bot
parent 18d8c48c01
commit 786df48b50
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ReactCommon/fabric/components/view/conversions.h
View File

@ -14,6 +14,7 @@
#include <folly/dynamic.h>
#include <yoga/YGNode.h>
#include <yoga/Yoga.h>
#include <cmath>
namespace facebook {
namespace react {
@ -51,7 +52,7 @@ inline YGFloatOptional yogaOptionalFloatFromFloat(Float value) {
}
inline YGValue yogaStyleValueFromFloat(const Float &value) {
if (isnan(value) || value == kFloatUndefined) {
if (std::isnan(value) || value == kFloatUndefined) {
return YGValueUndefined;
}

2
ReactCommon/fabric/core/layout/LayoutableShadowNode.h
View File

@ -28,6 +28,8 @@ struct LayoutContext;
*/
class LayoutableShadowNode : public virtual Sealable {
public:
virtual ~LayoutableShadowNode() noexcept = default;
/*
* Measures the node (and node content, propbably recursivly) with
* given constrains and relying on possible layout.