status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-14 19:44:13 +00:00
Code Issues Projects Releases Wiki Activity

Back out "[react-native][PR] Remove the deprecated isIPhoneX_deprecated constant"

Browse Source 
Summary:
Original commit changeset: 0b0b3a2d7b80

This constant is still in use at Facebook. Its removal has been pushed to sometime in the future.

Reviewed By: mdvacca

Differential Revision: D8721213

fbshipit-source-id: d1197c96804e4d2dc96be27421e5248a2394cdac
This commit is contained in:
Wenting Hu 2018-07-08 13:06:38 -07:00 committed by Facebook Github Bot
parent b99609e9d2
commit 781f181610
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
RNTester/js/SafeAreaViewExample.js
View File

@ -90,8 +90,8 @@ exports.examples = [
title: 'isIPhoneX_deprecated Example', title: 'isIPhoneX_deprecated Example',
description: description:
'`DeviceInfo.isIPhoneX_deprecated` returns true only on iPhone X. ' + '`DeviceInfo.isIPhoneX_deprecated` returns true only on iPhone X. ' +
'Note: This prop is deprecated and will be removed right after June 01, 2018. ' + 'Note: This prop is deprecated and will be removed in a future ' +
'Please use this only for a quick and temporary solution. ' + 'release. Please use this only for a quick and temporary solution. ' +
'Use <SafeAreaView> instead.', 'Use <SafeAreaView> instead.',
render: () => <IsIPhoneXExample />, render: () => <IsIPhoneXExample />,
}, },

2
React/Modules/RCTDeviceInfo.m
View File

@ -103,7 +103,7 @@ static NSDictionary *RCTExportedDimensions(RCTBridge *bridge)
return @{ return @{
@"Dimensions": RCTExportedDimensions(_bridge), @"Dimensions": RCTExportedDimensions(_bridge),
// Note: // Note:
// This prop is deprecated and will be removed right after June 01, 2018. // This prop is deprecated and will be removed in a future release.
// Please use this only for a quick and temporary solution. // Please use this only for a quick and temporary solution.
// Use <SafeAreaView> instead. // Use <SafeAreaView> instead.
@"isIPhoneX_deprecated": @(RCTIsIPhoneX()), @"isIPhoneX_deprecated": @(RCTIsIPhoneX()),