From 761089211f20f4f4901fe09019ec1c031006598b Mon Sep 17 00:00:00 2001 From: Ahmed El-Helw Date: Fri, 16 Dec 2016 11:55:11 -0800 Subject: [PATCH] Fix drawRect with NaN when drawing borders in Nodes Summary: drawRect was sometimes being called with NaN values, which caused very strange ui behavior on some devices. This patch fixes the problem by ensuring that we use a default value when the value is NaN. Reviewed By: AaaChiuuu Differential Revision: D4338453 --- .../src/main/java/com/facebook/react/flat/DrawBorder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/DrawBorder.java b/ReactAndroid/src/main/java/com/facebook/react/flat/DrawBorder.java index 9e3ae70a5..917a99bab 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/DrawBorder.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/DrawBorder.java @@ -407,7 +407,7 @@ import com.facebook.react.uimanager.Spacing; } private static float resolveWidth(float width, float defaultWidth) { - return width == 0 ? defaultWidth : width; + return (width == 0 || /* check for NaN */ width != width) ? defaultWidth : width; } private static DashPathEffect createDashPathEffect(float borderWidth) {