status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-27 16:40:38 +00:00
Code Issues Projects Releases Wiki Activity

Fix drawRect with NaN when drawing borders in Nodes

Browse Source 
Summary:
drawRect was sometimes being called with NaN values, which caused
very strange ui behavior on some devices. This patch fixes the problem by
ensuring that we use a default value when the value is NaN.

Reviewed By: AaaChiuuu

Differential Revision: D4338453
This commit is contained in:
Ahmed El-Helw 2016-12-16 11:55:11 -08:00
parent e9dba410eb
commit 761089211f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ReactAndroid/src/main/java/com/facebook/react/flat/DrawBorder.java
View File

@ -407,7 +407,7 @@ import com.facebook.react.uimanager.Spacing;
}
private static float resolveWidth(float width, float defaultWidth) {
return width == 0 ? defaultWidth : width;
return (width == 0 || /* check for NaN */ width != width) ? defaultWidth : width;
}
private static DashPathEffect createDashPathEffect(float borderWidth) {