Refactor FabricBinding class
Summary: This diff removes the FabricBinding interface becuase it is not needed anymore. Reviewed By: sahrens Differential Revision: D13707494 fbshipit-source-id: 7b50dcd40559356464a860ba32d9a0130ab2da6e
This commit is contained in:
parent
4802cffa14
commit
707622ac84
|
@ -1,25 +0,0 @@
|
||||||
/**
|
|
||||||
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
||||||
*
|
|
||||||
* <p>This source code is licensed under the MIT license found in the LICENSE file in the root
|
|
||||||
* directory of this source tree.
|
|
||||||
*/
|
|
||||||
package com.facebook.react.fabric;
|
|
||||||
|
|
||||||
import com.facebook.react.bridge.JavaScriptContextHolder;
|
|
||||||
import com.facebook.react.bridge.queue.MessageQueueThread;
|
|
||||||
import com.facebook.react.fabric.jsi.ComponentFactoryDelegate;
|
|
||||||
import com.facebook.react.fabric.jsi.EventBeatManager;
|
|
||||||
|
|
||||||
public interface FabricBinding {
|
|
||||||
|
|
||||||
// TODO: T31905686 change types of UIManager and EventBeatManager when moving to OSS
|
|
||||||
void register(
|
|
||||||
JavaScriptContextHolder jsContext,
|
|
||||||
FabricUIManager fabricUIManager,
|
|
||||||
EventBeatManager eventBeatManager,
|
|
||||||
MessageQueueThread jsMessageQueueThread,
|
|
||||||
ComponentFactoryDelegate componentFactoryDelegate);
|
|
||||||
|
|
||||||
void unregister();
|
|
||||||
}
|
|
|
@ -39,7 +39,7 @@ public class FabricJSIModuleProvider implements JSIModuleProvider<UIManager> {
|
||||||
final FabricUIManager uiManager = createUIManager(eventBeatManager);
|
final FabricUIManager uiManager = createUIManager(eventBeatManager);
|
||||||
Systrace.beginSection(
|
Systrace.beginSection(
|
||||||
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricJSIModuleProvider.registerBinding");
|
Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricJSIModuleProvider.registerBinding");
|
||||||
final FabricBinding binding = new Binding();
|
final Binding binding = new Binding();
|
||||||
MessageQueueThread jsMessageQueueThread =
|
MessageQueueThread jsMessageQueueThread =
|
||||||
mReactApplicationContext
|
mReactApplicationContext
|
||||||
.getCatalystInstance()
|
.getCatalystInstance()
|
||||||
|
|
|
@ -12,13 +12,12 @@ import com.facebook.proguard.annotations.DoNotStrip;
|
||||||
import com.facebook.react.bridge.JavaScriptContextHolder;
|
import com.facebook.react.bridge.JavaScriptContextHolder;
|
||||||
import com.facebook.react.bridge.NativeMap;
|
import com.facebook.react.bridge.NativeMap;
|
||||||
import com.facebook.react.bridge.queue.MessageQueueThread;
|
import com.facebook.react.bridge.queue.MessageQueueThread;
|
||||||
import com.facebook.react.fabric.FabricBinding;
|
|
||||||
import com.facebook.react.fabric.FabricUIManager;
|
import com.facebook.react.fabric.FabricUIManager;
|
||||||
import com.facebook.react.uimanager.PixelUtil;
|
import com.facebook.react.uimanager.PixelUtil;
|
||||||
|
|
||||||
@DoNotStrip
|
@DoNotStrip
|
||||||
@SuppressLint("MissingNativeLoadLibrary")
|
@SuppressLint("MissingNativeLoadLibrary")
|
||||||
public class Binding implements FabricBinding {
|
public class Binding {
|
||||||
|
|
||||||
static {
|
static {
|
||||||
FabricSoLoader.staticInit();
|
FabricSoLoader.staticInit();
|
||||||
|
@ -50,7 +49,6 @@ public class Binding implements FabricBinding {
|
||||||
public native void setConstraints(
|
public native void setConstraints(
|
||||||
int rootTag, float minWidth, float maxWidth, float minHeight, float maxHeight);
|
int rootTag, float minWidth, float maxWidth, float minHeight, float maxHeight);
|
||||||
|
|
||||||
@Override
|
|
||||||
public void register(
|
public void register(
|
||||||
JavaScriptContextHolder jsContext,
|
JavaScriptContextHolder jsContext,
|
||||||
FabricUIManager fabricUIManager,
|
FabricUIManager fabricUIManager,
|
||||||
|
@ -65,7 +63,6 @@ public class Binding implements FabricBinding {
|
||||||
|
|
||||||
private native void uninstallFabricUIManager();
|
private native void uninstallFabricUIManager();
|
||||||
|
|
||||||
@Override
|
|
||||||
public void unregister() {
|
public void unregister() {
|
||||||
uninstallFabricUIManager();
|
uninstallFabricUIManager();
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue