status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Minor fixes in comments 

Reviewed By: @mkonicek

Differential Revision: D2463595

committer: Service User <svcscm@fb.com>
This commit is contained in:
Martin Konicek 2015-09-21 13:30:08 -07:00 committed by facebook-github-bot-4
parent 8f5b2ccbe0
commit 6b733bdcf1
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ReactAndroid/build.gradle
View File

@ -10,8 +10,8 @@ import org.apache.tools.ant.taskdefs.condition.Os
import org.apache.tools.ant.filters.ReplaceTokens import org.apache.tools.ant.filters.ReplaceTokens
// We download various C++ open-source dependencies into downloads. // We download various C++ open-source dependencies into downloads.
// We then copy both downloaded code and our custom makefiles and headers into third-party-ndk // We then copy both the downloaded code and our custom makefiles and headers into third-party-ndk.
// After that we build native code from src/main/jni with module path pointing at third-party-ndk // After that we build native code from src/main/jni with module path pointing at third-party-ndk.
def downloadsDir = new File("$buildDir/downloads") def downloadsDir = new File("$buildDir/downloads")
def thirdPartyNdkDir = new File("$buildDir/third-party-ndk") def thirdPartyNdkDir = new File("$buildDir/third-party-ndk")
@ -243,4 +243,3 @@ dependencies {
} }
apply from: 'release.gradle' apply from: 'release.gradle'

4
ReactAndroid/src/main/jni/react/JSCExecutor.cpp
View File

@ -137,8 +137,8 @@ static JSValueRef nativeLoggingHook(
android_LogPriority logLevel = ANDROID_LOG_DEBUG; android_LogPriority logLevel = ANDROID_LOG_DEBUG;
if (argumentCount > 1) { if (argumentCount > 1) {
int level = (int) JSValueToNumber(ctx, arguments[1], NULL); int level = (int) JSValueToNumber(ctx, arguments[1], NULL);
// The lowest log level we get from JS is 0. We shift and cap it to be // The lowest log level we get from JS is 0. We shift and cap it to be
// in the range Android logging method expects. // in the range the Android logging method expects.
logLevel = std::min( logLevel = std::min(
static_cast<android_LogPriority>(level + ANDROID_LOG_VERBOSE), static_cast<android_LogPriority>(level + ANDROID_LOG_VERBOSE),
ANDROID_LOG_FATAL); ANDROID_LOG_FATAL);