From 2429324e799c2c74d697c649c17d66b5cb766493 Mon Sep 17 00:00:00 2001 From: Christopher Date: Sat, 30 May 2015 00:12:17 -0700 Subject: [PATCH 1/4] [Docs] Gramatical change / Timer --- docs/Timers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Timers.md b/docs/Timers.md index 9e652e8cc..b4ff4f203 100644 --- a/docs/Timers.md +++ b/docs/Timers.md @@ -71,4 +71,4 @@ var Component = React.createClass({ }); ``` -We highly recommend never using bare timers and always using this mixin, it will save you from a lot of hard to track down bugs. +We strongly discourage using bare timers and always recommend using this mixin. This will eliminate a lot of hard tracking down bugs. From 5918be23258fac3683339328fb729c9e839fe7e8 Mon Sep 17 00:00:00 2001 From: Christopher Dro Date: Sat, 30 May 2015 00:46:30 -0700 Subject: [PATCH 2/4] Typo Fix Oddly enough, adding `work` was the first change I wanted to do. :) --- docs/Timers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Timers.md b/docs/Timers.md index b4ff4f203..974083c61 100644 --- a/docs/Timers.md +++ b/docs/Timers.md @@ -71,4 +71,4 @@ var Component = React.createClass({ }); ``` -We strongly discourage using bare timers and always recommend using this mixin. This will eliminate a lot of hard tracking down bugs. +We strongly discourage using bare timers and always recommend using this mixin. This will eliminate a lot of hard work tracking down bugs. From 47e56d778a5254a185fff7a36e41c2bba3a17bef Mon Sep 17 00:00:00 2001 From: Christopher Dro Date: Sat, 30 May 2015 14:47:24 -0700 Subject: [PATCH 3/4] Re-wording --- docs/Timers.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/Timers.md b/docs/Timers.md index 974083c61..dd6152c98 100644 --- a/docs/Timers.md +++ b/docs/Timers.md @@ -71,4 +71,5 @@ var Component = React.createClass({ }); ``` -We strongly discourage using bare timers and always recommend using this mixin. This will eliminate a lot of hard work tracking down bugs. +We strongly discourage using `setTimeout(...)` and recommend using `this.setTimeout(...)`. +This will eliminate a lot of hard work tracking down bugs. From 597f9d94fd3077d34b76faf5f636352d240e2cf6 Mon Sep 17 00:00:00 2001 From: Christopher Dro Date: Sat, 30 May 2015 18:00:34 -0700 Subject: [PATCH 4/4] Changes based on @brentvatne revision --- docs/Timers.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/Timers.md b/docs/Timers.md index dd6152c98..44cc093ae 100644 --- a/docs/Timers.md +++ b/docs/Timers.md @@ -71,5 +71,4 @@ var Component = React.createClass({ }); ``` -We strongly discourage using `setTimeout(...)` and recommend using `this.setTimeout(...)`. -This will eliminate a lot of hard work tracking down bugs. +We strongly discourage using the global `setTimeout(...)` and recommend instead that you use `this.setTimeout(...)` provided by react-timer-mixin. This will eliminate a lot of hard work tracking down bugs, such as crashes caused by timeouts firing after a component has been unmounted.