status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

[ReactNative|Easy] Change watchman too-long error message 

Summary:
@wez Mentioned this in Issue #239 -- right now when watchman takes too long we recommend you run `watchman` from your terminal which actually expects some arguments, so it prints out the following:

```
[pcottle:~/Desktop/react-native:changeErrorMessage]$ watchman
{
    "error": "invalid command (expected an array with some elements!)",
    "cli_validated": true,
    "version": "3.0.0"
}
```

basically this ends up being more confusing since the command we recommend you run errors out, so lets change it to `watchman version` which at least exists cleanly.

I kept the troubleshooting link as https://facebook.github.io/watchman/docs/troubleshooting.html since it sounds like we will update that with the issue people run into in #239
Closes https://github.com/facebook/react-native/pull/825
Github Author: Peter Cottle <pcottle@fb.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
This commit is contained in:
Peter Cottle 2015-04-17 09:10:20 -07:00
parent 2975f26e80
commit 691297ab0d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packager/react-packager/src/FileWatcher/index.js vendored
View File

@ -73,7 +73,7 @@ function createWatcher(rootConfig) {
var rejectTimeout = setTimeout(function() { var rejectTimeout = setTimeout(function() {
reject(new Error([ reject(new Error([
'Watcher took too long to load', 'Watcher took too long to load',
'Try running `watchman` from your terminal', 'Try running `watchman version` from your terminal',
'https://facebook.github.io/watchman/docs/troubleshooting.html', 'https://facebook.github.io/watchman/docs/troubleshooting.html',
].join('\n'))); ].join('\n')));
}, MAX_WAIT_TIME); }, MAX_WAIT_TIME);