status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-30 19:25:11 +00:00
Code Issues Projects Releases Wiki Activity

Improves react image loading handlers to mimic iOS behavior

Browse Source 
Reviewed By: vjeux

Differential Revision: D3283011

fbshipit-source-id: acb04f8b2ccbab99a59040a7ca70aa46cbf73faa
This commit is contained in:
Olivier Notteghem 2016-05-10 14:16:26 -07:00 committed by Facebook Github Bot 5
parent c1f0ce283c
commit 68b2f49a31
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ReactAndroid/src/main/java/com/facebook/react/views/image/ImageLoadEvent.java
View File

@ -26,7 +26,7 @@ public class ImageLoadEvent extends Event<ImageLoadEvent> {
@Retention(RetentionPolicy.SOURCE) @Retention(RetentionPolicy.SOURCE)
@interface ImageEventType {} @interface ImageEventType {}
// Currently ON_ERROR and ON_PROGRESS are not implemented, these can be added // Currently ON_PROGRESS is not implemented, these can be added
// easily once support exists in fresco. // easily once support exists in fresco.
public static final int ON_ERROR = 1; public static final int ON_ERROR = 1;
public static final int ON_LOAD = 2; public static final int ON_LOAD = 2;

9
ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java
View File

@ -193,10 +193,10 @@ public class ReactImageView extends GenericDraweeView {
@Nullable Animatable animatable) { @Nullable Animatable animatable) {
if (imageInfo != null) { if (imageInfo != null) {
mEventDispatcher.dispatchEvent( mEventDispatcher.dispatchEvent(
new ImageLoadEvent(getId(), SystemClock.nanoTime(), ImageLoadEvent.ON_LOAD_END) new ImageLoadEvent(getId(), SystemClock.nanoTime(), ImageLoadEvent.ON_LOAD)
); );
mEventDispatcher.dispatchEvent( mEventDispatcher.dispatchEvent(
new ImageLoadEvent(getId(), SystemClock.nanoTime(), ImageLoadEvent.ON_LOAD) new ImageLoadEvent(getId(), SystemClock.nanoTime(), ImageLoadEvent.ON_LOAD_END)
); );
} }
} }
@ -204,7 +204,10 @@ public class ReactImageView extends GenericDraweeView {
@Override @Override
public void onFailure(String id, Throwable throwable) { public void onFailure(String id, Throwable throwable) {
mEventDispatcher.dispatchEvent( mEventDispatcher.dispatchEvent(
new ImageLoadEvent(getId(), SystemClock.nanoTime(), ImageLoadEvent.ON_LOAD_END) new ImageLoadEvent(getId(), SystemClock.nanoTime(), ImageLoadEvent.ON_ERROR)
);
mEventDispatcher.dispatchEvent(
new ImageLoadEvent(getId(), SystemClock.nanoTime(), ImageLoadEvent.ON_LOAD_END)
); );
} }
}; };