Fix Text incorrect line height
Summary: @public Setting the line height with the help of Android-provided StaticLayout is incorrect. A simple example app will display the following when `setLineSpacing(50.f, 0.f)` is set: {F62987699}. You'll notice that the height of the first line is a few pixels shorter than the other lines. So we use a custom LineHeightSpan instead, which needs to be applied to the text itself, and no height-related attributes need to be set on the TextView itself. Reviewed By: lexs Differential Revision: D3751097
This commit is contained in:
parent
3da695fe88
commit
66bbd78fe3
|
@ -129,7 +129,7 @@ public class RCTTextInput extends RCTVirtualText implements AndroidView, CSSNode
|
||||||
super.onCollectExtraUpdates(uiViewOperationQueue);
|
super.onCollectExtraUpdates(uiViewOperationQueue);
|
||||||
if (mJsEventCount != UNSET) {
|
if (mJsEventCount != UNSET) {
|
||||||
ReactTextUpdate reactTextUpdate =
|
ReactTextUpdate reactTextUpdate =
|
||||||
new ReactTextUpdate(getText(), mJsEventCount, false, getPadding(), Float.NaN, UNSET);
|
new ReactTextUpdate(getText(), mJsEventCount, false, getPadding(), UNSET);
|
||||||
// TODO: the Float.NaN should be replaced with the real line height see D3592781
|
// TODO: the Float.NaN should be replaced with the real line height see D3592781
|
||||||
uiViewOperationQueue.enqueueUpdateExtraData(getReactTag(), reactTextUpdate);
|
uiViewOperationQueue.enqueueUpdateExtraData(getReactTag(), reactTextUpdate);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue