status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

[ReactNative] Don't redbox for React warnings when not using Chrome executor

This commit is contained in:
Ben Alpert 2015-08-17 14:56:10 -07:00
parent 8d1e02b8bd
commit 65692b7235
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/JavaScriptAppEngine/Initialization/ExceptionsManager.js
View File

@ -80,6 +80,9 @@ function installConsoleErrorReporter() {
console.reportException = reportException;
console.errorOriginal = console.error.bind(console);
console.error = function reactConsoleError() {
// Note that when using the built-in context executor on iOS (i.e., not
// Chrome debugging), console.error is already stubbed out to cause a
// redbox via RCTNativeLoggingHook.
console.errorOriginal.apply(null, arguments);
if (!console.reportErrorsAsExceptions) {
return;
@ -88,6 +91,7 @@ function installConsoleErrorReporter() {
if (str.slice(0, 10) === '"Warning: ') {
// React warnings use console.error so that a stack trace is shown, but
// we don't (currently) want these to show a redbox
// (Note: Logic duplicated in polyfills/console.js.)
return;
}
var error: any = new Error('console.error: ' + str);

6
packager/react-packager/src/DependencyResolver/polyfills/console.js vendored
View File

@ -376,6 +376,12 @@
var str = Array.prototype.map.call(arguments, function(arg) {
return inspect(arg, {depth: 10});
}).join(', ');
if (str.slice(0, 10) === "'Warning: " && level >= LOG_LEVELS.error) {
// React warnings use console.error so that a stack trace is shown,
// but we don't (currently) want these to show a redbox
// (Note: Logic duplicated in ExceptionsManager.js.)
level = LOG_LEVELS.warn;
}
global.nativeLoggingHook(str, level);
};
}