status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Automatically start JSC profiling if enabled on last run 

Summary: @​public

Using the saved state of the toggle button, this starts profiling automatically when the `RCTContextExecutor` is set up, if it was profiling before.

Reviewed By: @tadeuzagallo

Differential Revision: D2429026
This commit is contained in:
Justin Spahr-Summers 2015-09-15 02:49:04 -07:00 committed by facebook-github-bot-7
parent 4fd0a2de0d
commit 6484173b88
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
React/Executors/RCTContextExecutor.m
View File

@ -33,6 +33,8 @@
#if RCT_JSC_PROFILER
#include <dlfcn.h>
static NSString * const RCTJSCProfilerEnabledDefaultsKey = @"RCTJSCProfilerEnabled";
#ifndef RCT_JSC_PROFILER_DYLIB
#define RCT_JSC_PROFILER_DYLIB [[[NSBundle mainBundle] pathForResource:[NSString stringWithFormat:@"RCTJSCProfiler.ios%zd", [[[UIDevice currentDevice] systemVersion] integerValue]] ofType:@"dylib" inDirectory:@"RCTJSCProfiler"] UTF8String]
#endif
@ -224,9 +226,10 @@ static void RCTInstallJSCProfiler(RCTBridge *bridge, JSContextRef context)
nativeProfilerEnableByteCode();
}
__block BOOL isProfiling = NO;
[bridge.devMenu addItem:[RCTDevMenuItem buttonItemWithTitle:@"Profile" handler:^{
if (isProfiling) {
[bridge.devMenu addItem:[RCTDevMenuItem toggleItemWithKey:RCTJSCProfilerEnabledDefaultsKey title:@"Start Profiling" selectedTitle:@"Stop Profiling" handler:^(BOOL shouldStart) {
if (shouldStart) {
nativeProfilerStart(context, "profile");
} else {
NSString *outputFile = [NSTemporaryDirectory() stringByAppendingPathComponent:@"cpu_profile.json"];
nativeProfilerEnd(context, "profile", outputFile.UTF8String);
NSData *profileData = [NSData dataWithContentsOfFile:outputFile
@ -234,10 +237,7 @@ static void RCTInstallJSCProfiler(RCTBridge *bridge, JSContextRef context)
error:NULL];
RCTProfileSendResult(bridge, @"cpu-profile", profileData);
} else {
nativeProfilerStart(context, "profile");
}
isProfiling = !isProfiling;
}]];
}
}