From 6426735e825a466d9e2e1c27c22dbfad6329d395 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= <hramos@fb.com>
Date: Fri, 16 Mar 2018 16:48:45 -0700
Subject: [PATCH] Simplify templates

Summary:
Trivial PR.

[GENERAL][MINOR][.circleci/, bots/] - Simplify GitHub templates
Closes https://github.com/facebook/react-native/pull/18418

Differential Revision: D7311869

Pulled By: hramos

fbshipit-source-id: b87599c53938406d585d711492aacbdde2fcb02a
---
 .github/ISSUE_TEMPLATE.md         | 40 +++++++++++-----------
 .github/PULL_REQUEST_TEMPLATE.md  | 55 ++++++++++++++++---------------
 .github/no-response.yml           |  9 -----
 bots/NewIssueGreeting.md          |  9 -----
 bots/QuestionGreeting.md          |  5 ---
 bots/dangerfile.js                | 26 +--------------
 bots/pr-inactivity-bookmarklet.js |  1 -
 bots/question-bookmarklet.js      |  1 -
 breaking-changes.md               |  3 --
 9 files changed, 49 insertions(+), 100 deletions(-)
 delete mode 100644 .github/no-response.yml
 delete mode 100644 bots/NewIssueGreeting.md
 delete mode 100644 bots/QuestionGreeting.md
 delete mode 100644 bots/pr-inactivity-bookmarklet.js
 delete mode 100644 bots/question-bookmarklet.js
 delete mode 100644 breaking-changes.md

diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
index bbe1d31e0..46d7bb476 100644
--- a/.github/ISSUE_TEMPLATE.md
+++ b/.github/ISSUE_TEMPLATE.md
@@ -1,29 +1,27 @@
 <!--
   We use GitHub Issues exclusively for tracking bugs in React Native.
-  Please follow this template when preparing your bug report.
+  Questions? Visit http://facebook.github.io/react-native/help.html
+  If this issue is about documentation or the website, please file it at:
+  https://github.com/facebook/react-native-website/issues/new
 -->
 
-(Describe your issue in detail.)
+- [ ] I have reviewed the [documentation](https://facebook.github.io/react-native)
+- [ ] I have searched [existing issues](https://github.com/facebook/react-native/issues)
+- [ ] I am using the [latest React Native version](https://github.com/facebook/react-native/releases)
 
-### Environment
+<!-- Describe your issue in detail. -->
 
-(Run `react-native info` in your terminal and paste its contents here.)
+## Environment
+<!-- Required. Run `react-native info` in your terminal and paste its contents here. -->
 
-### Expected Behavior
-
-(Write what you thought would happen.)
-
-### Actual Behavior
-
-(Write what happened. Include screenshots if needed.)
-
-### Steps to Reproduce
-
-(Link to Snack, or steps to reproduce.)
-
-<!--
-  Please share a project that reproduces the issue. 
-  Ideally, create a new app using https://snack.expo.io/ and try to reproduce the issue in it.
-
-  This is a good guide to creating bug demos: https://stackoverflow.com/help/mcve
+## Steps to Reproduce
+<!-- 
+  Required. Let us know how to reproduce the issue. Include a code sample, share a project, 
+  or share an app that reproduces the issue using [Snack](https://snack.expo.io/).
 -->
+
+## Expected Behavior
+<!-- Write what you thought would happen. -->
+
+## Actual Behavior
+<!-- Write what happened. Include screenshots if needed. If this is a regression, let us know. -->
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index d8a1469f3..93f140001 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,43 +1,46 @@
-<!--
 Thank you for sending the PR! We appreciate you spending the time to work on these changes. 
-
 Help us understand your motivation by explaining why you decided to make this change.
 
-You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
-
-Happy contributing!
-
+<!-- 
+  Required: Write your motivation here.
+  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
 -->
 
-## Motivation
-
-(Write your motivation here.)
-
 ## Test Plan
 
-(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
+<!-- 
+  Required: Write your test plan here. If you changed any code, please provide us with 
+  clear instructions on how you verified your changes work. Bonus points for screenshots and videos! 
+-->
 
 ## Related PRs
 
-(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)
+<!-- 
+  Does this PR require a documentation change? 
+  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
+-->
 
 ## Release Notes
+
+<!-- 
+  Required. 
+  Help reviewers and the release process by writing your own release notes. See below for an example.
+-->
+
+[CATEGORY] [TYPE] [LOCATION] - Message
+
 <!--
-Help reviewers and the release process by writing your own release notes
+  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
 
-**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
-
-  CATEGORY
-[----------]        TYPE
-[ CLI      ]   [-------------]      LOCATION
-[ DOCS     ]   [ BREAKING    ]   [-------------]
-[ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
-[ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
-[ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
-[ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
-[----------]   [-------------]   [-------------]   |-----------|
-
-[CATEGORY] [TYPE] [LOCATION] - MESSAGE
+    CATEGORY
+  [----------]      TYPE
+  [ CLI      ] [-------------]    LOCATION
+  [ DOCS     ] [ BREAKING    ] [-------------]
+  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
+  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
+  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
+  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
+  [----------] [-------------] [-------------]   |-----------|
 
  EXAMPLES:
 
diff --git a/.github/no-response.yml b/.github/no-response.yml
deleted file mode 100644
index 242036334..000000000
--- a/.github/no-response.yml
+++ /dev/null
@@ -1,9 +0,0 @@
-# Configuration for probot-no-response - https://github.com/probot/no-response
-
-# Number of days of inactivity before an Issue is closed for lack of response
-daysUntilClose: 14
-# Label requiring a response
-responseRequiredLabel: Needs more information
-# Comment to post when closing an Issue for lack of response. Set to `false` to disable
-closeComment: >
-  Closing this issue as more information is needed to debug this and we have not heard back from the author.
diff --git a/bots/NewIssueGreeting.md b/bots/NewIssueGreeting.md
deleted file mode 100644
index 1d3ccd997..000000000
--- a/bots/NewIssueGreeting.md
+++ /dev/null
@@ -1,9 +0,0 @@
-Hey {author}, thanks for reporting this issue!
-
-React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.
-
-- If you **don't know how to do something** or **something is not working as you expect but not sure it's a bug**, please ask on [StackOverflow](https://stackoverflow.com/questions/tagged/react-native) with the tag `react-native` or for more real time interactions, ask on [Discord](https://discord.gg/0ZcbPKXt5bZjGY5n) in the #react-native channel.
-
-- If this is a **feature request or a bug** that you would like to be fixed, please report it on [Canny](https://react-native.canny.io/feature-requests). It has a ranking feature that lets us focus on the most important issues the community is experiencing.
-
-- We welcome clear issues and PRs that are ready for in-depth discussion. Please provide **screenshots** where appropriate and always mention the **version** of React Native you're using. Thank you for your contributions!
diff --git a/bots/QuestionGreeting.md b/bots/QuestionGreeting.md
deleted file mode 100644
index a63b273b5..000000000
--- a/bots/QuestionGreeting.md
+++ /dev/null
@@ -1,5 +0,0 @@
-*By analyzing the title and description for some common words it looks like this issue might be a question. I'm just a bot and might be wrong. In that case please cc mkonicek, he would like to know about it :)*
-
-Please consider using [Stack Overflow](https://stackoverflow.com/questions/tagged/react-native) for questions. It's the best system for Q&A and the best way to get questions answered.
-
-Many people from the community hang out on Stack Overflow and will be able to see your question and be more likely to answer because of the reputation system. If after reading this you think your question is better suited for Stack Overflow, please consider closing this issue.
diff --git a/bots/dangerfile.js b/bots/dangerfile.js
index 9c9218b34..b97ecaf8e 100644
--- a/bots/dangerfile.js
+++ b/bots/dangerfile.js
@@ -18,14 +18,6 @@ if (!danger.github.pr.body || danger.github.pr.body.length < 10) {
   fail(':grey_question: This pull request needs a description.');
 }
 
-// Warns if the PR title contains [WIP]
-const isWIP = includes(danger.github.pr.title, '[WIP]');
-if (isWIP) {
-  const title = ':construction_worker: Work In Progress';
-  const idea = 'This PR appears to be a work in progress, and may not be ready to be merged yet.';
-  warn(`${title} - <i>${idea}</i>`);
-}
-
 // Warns if there are changes to package.json, and tags the team.
 const packageChanged = includes(danger.git.modified_files, 'package.json');
 if (packageChanged) {
@@ -44,10 +36,9 @@ if (!includesTestPlan) {
 }
 
 // Regex looks for given categories, types, a file/framework/component, and a message - broken into 4 capture groups
-const releaseNotesRegex = /\[(ANDROID|CLI|DOCS|GENERAL|INTERNAL|IOS|TVOS|WINDOWS)\]\s*?\[(BREAKING|BUGFIX|ENHANCEMENT|FEATURE|MINOR)\]\s*?\[(.*)\]\s*?\-\s*?(.*)/ig;
+const releaseNotesRegex = /\[\s?(ANDROID|CLI|DOCS|GENERAL|INTERNAL|IOS|TVOS|WINDOWS)\s?\]\s*?\[\s?(BREAKING|BUGFIX|ENHANCEMENT|FEATURE|MINOR)\s?\]\s*?\[(.*)\]\s*?\-\s*?(.*)/ig;
 const includesReleaseNotes = danger.github.pr.body && danger.github.pr.body.toLowerCase().includes('release notes');
 const correctlyFormattedReleaseNotes = releaseNotesRegex.test(danger.github.pr.body);
-const releaseNotesCaptureGroups = releaseNotesRegex.exec(danger.github.pr.body);
 
 if (!includesReleaseNotes) {
   const title = ':clipboard: Release Notes';
@@ -57,21 +48,6 @@ if (!includesReleaseNotes) {
   const title = ':clipboard: Release Notes';
   const idea = 'This PR may have incorrectly formatted Release Notes.';
   warn(`${title} - <i>${idea}</i>`);
-} else if (releaseNotesCaptureGroups) {
-  const category = releaseNotesCaptureGroups[1].toLowerCase();
-
-  // Use Release Notes to Tag PRs appropriately
-  if (category === 'ios' || category === 'tvos') {
-    message('Suggested label: iOS');
-  }
-
-  if (category === 'android') {
-    message('Suggested label: Android');
-  }
-
-  if (category === 'cli') {
-    message('Suggested label: Tooling');
-  }
 }
 
 // Tags big PRs
diff --git a/bots/pr-inactivity-bookmarklet.js b/bots/pr-inactivity-bookmarklet.js
deleted file mode 100644
index f0c363922..000000000
--- a/bots/pr-inactivity-bookmarklet.js
+++ /dev/null
@@ -1 +0,0 @@
-javascript:(function(){$('#new_comment_field')[0].value='Hey @' + $(".timeline-comment-header-text").first().find(".author").text() + '! Thanks for making the pull request, but we are closing it due to inactivity (' + Math.round(Math.abs((Date.now() - new Date($(".timeline-comment-header-text").last().find("time").attr("datetime")).getTime())/(24*60*60*1000))) + ' days with no activity). If you want to get your proposed changes merged, please rebase your branch with master and send a new pull request. :)';/*$('button.btn-primary:contains("Comment")').click()*/})()
diff --git a/bots/question-bookmarklet.js b/bots/question-bookmarklet.js
deleted file mode 100644
index 0e16164c2..000000000
--- a/bots/question-bookmarklet.js
+++ /dev/null
@@ -1 +0,0 @@
-javascript:(function(){$('#new_comment_field')[0].value='Hey @' + $(".timeline-comment-header-text").first().find(".author").text() + '! Thanks for reporting this!\n\nThere\'s an awesome place to ask question like this one: [StackOverflow](http://stackoverflow.com/questions/tagged/react-native). It\'s the best system for Q&A. Many people from the community hang out there and will be able to see your question, you can vote on answers and mark question as answered etc. This lets us keep a list of bug reports and feature requests on github and especially [Canny](https://react-native.canny.io/feature-requests) (again, with voting which is really nice).\n\nIf you think StackOverflow works for you please consider posting there instead and closing this issue.\n\nI\'m posting this here because github issues haven\'t been working very well for us and because StackOverflow is so much better. Thanks for reading! :)';$('button.btn-primary:contains("Comment")').click()})()
diff --git a/breaking-changes.md b/breaking-changes.md
deleted file mode 100644
index ccf4fef17..000000000
--- a/breaking-changes.md
+++ /dev/null
@@ -1,3 +0,0 @@
-# Breaking Changes
-
-**Breaking changes are now tracked in [the Wiki](https://github.com/facebook/react-native/wiki/Breaking-Changes)**.