status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-24 23:28:12 +00:00
Code Issues Projects Releases Wiki Activity

Fabric: Subtle changes that make GCC compiler happy

Browse Source 
Summary:
@public
Most of them are legit issues which should not be compilable anyways (but Clang tolerates thems).

Reviewed By: mdvacca

Differential Revision: D8655539

fbshipit-source-id: 645729fb9d6a120ce1ab2b07542abcdacd72320d
This commit is contained in:
Valentin Shergin 2018-06-29 12:09:59 -07:00 committed by Facebook Github Bot
parent 712c2ed5d2
commit 62f9ced099
9 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ReactCommon/fabric/core/layout/LayoutableShadowNode.h
View File

@ -10,6 +10,7 @@
#include <array>
#include <cmath>
#include <vector>
#include <memory>
#include <fabric/core/LayoutMetrics.h>
#include <fabric/core/Sealable.h>
@ -23,7 +24,7 @@ struct LayoutContext;
class LayoutableShadowNode;
using SharedLayoutableShadowNode = std::shared_ptr<const LayoutableShadowNode>;
using SharedLayoutableShadowNodeList = std::vector<const SharedLayoutableShadowNode>;
using SharedLayoutableShadowNodeList = std::vector<SharedLayoutableShadowNode>;
using LayoutableShadowNodeIterator = std::iterator<std::input_iterator_tag, const SharedLayoutableShadowNode>;
/*

2
ReactCommon/fabric/core/shadownode/ShadowNode.cpp
View File

@ -7,6 +7,8 @@
#include "ShadowNode.h"
#include <string>
#include <fabric/debug/DebugStringConvertible.h>
#include <fabric/debug/DebugStringConvertibleItem.h>

3
ReactCommon/fabric/debug/DebugStringConvertible.h
View File

@ -8,6 +8,7 @@
#pragma once
#include <string>
#include <memory>
#include <vector>
namespace facebook {
@ -16,7 +17,7 @@ namespace react {
class DebugStringConvertible;
using SharedDebugStringConvertible = std::shared_ptr<const DebugStringConvertible>;
using SharedDebugStringConvertibleList = std::vector<const SharedDebugStringConvertible>;
using SharedDebugStringConvertibleList = std::vector<SharedDebugStringConvertible>;
struct DebugStringConvertibleOptions {
bool format {true};

2
ReactCommon/fabric/debug/DebugStringConvertibleItem.h
View File

@ -7,6 +7,8 @@
#pragma once
#include <string>
#include <fabric/debug/DebugStringConvertible.h>
namespace facebook {

9
ReactCommon/fabric/text/basetext/BaseTextShadowNode.cpp
View File

@ -8,11 +8,10 @@
#include "BaseTextShadowNode.h"
#include <fabric/debug/DebugStringConvertibleItem.h>
#include "RawTextShadowNode.h"
#include "RawTextProps.h"
#include "TextShadowNode.h"
#include "TextProps.h"
#include <fabric/text/RawTextShadowNode.h>
#include <fabric/text/RawTextProps.h>
#include <fabric/text/TextShadowNode.h>
#include <fabric/text/TextProps.h>
namespace facebook {
namespace react {

2
ReactCommon/fabric/uimanager/Differentiator.cpp
View File

@ -30,7 +30,7 @@ static void calculateMutationInstructions(
return;
}
std::unordered_set<Tag> insertedTags = {};
std::unordered_set<Tag> insertedTags;
int index = 0;
TreeMutationInstructionList createInstructions = {};

3
ReactCommon/fabric/uimanager/ShadowTree.h
View File

@ -7,7 +7,6 @@
#include <memory>
#include <mutex>
#include <stdatomic.h>
#include <fabric/core/LayoutConstraints.h>
#include <fabric/core/ReactPrimitives.h>
@ -84,7 +83,7 @@ private:
const Tag rootTag_;
SharedRootShadowNode rootShadowNode_;
ShadowTreeDelegate *delegate_;
mutable std::mutex commitMutex_ {};
mutable std::mutex commitMutex_;
};
} // namespace react

3
ReactCommon/fabric/view/root/RootProps.cpp
View File

@ -8,8 +8,7 @@
#include "RootProps.h"
#include <fabric/view/conversions.h>
#include "YogaLayoutableShadowNode.h"
#include <fabric/view/YogaLayoutableShadowNode.h>
namespace facebook {
namespace react {

2
ReactCommon/fabric/view/yoga/YogaLayoutableShadowNode.h
View File

@ -26,7 +26,7 @@ class YogaLayoutableShadowNode;
using SharedYogaConfig = std::shared_ptr<YGConfig>;
using SharedYogaLayoutableShadowNode = std::shared_ptr<const YogaLayoutableShadowNode>;
using SharedYogaLayoutableShadowNodeList = std::vector<const SharedYogaLayoutableShadowNode>;
using SharedYogaLayoutableShadowNodeList = std::vector<SharedYogaLayoutableShadowNode>;
using SharedYogaLayoutableShadowNodeSharedList = std::shared_ptr<const SharedYogaLayoutableShadowNodeList>;
class YogaLayoutableShadowNode: