From 842ce5109905908eb5cc9723a7cbd91218f33693 Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Mon, 27 Jul 2015 11:11:59 -0700 Subject: [PATCH 1/3] [Treehouse RN] Make smoothScrollTo works by not calling it twice --- Libraries/CustomComponents/ListView/ListView.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Libraries/CustomComponents/ListView/ListView.js b/Libraries/CustomComponents/ListView/ListView.js index 5ca25fe01..4554eb681 100644 --- a/Libraries/CustomComponents/ListView/ListView.js +++ b/Libraries/CustomComponents/ListView/ListView.js @@ -390,6 +390,13 @@ var ListView = React.createClass({ Object.assign(props, { onScroll: this._onScroll, stickyHeaderIndices: sectionHeaderIndices, + + // Do not pass these events downstream to ScrollView since they will be + // registered in ListView's own ScrollResponder.Mixin + onKeyboardWillShow: undefined, + onKeyboardWillHide: undefined, + onKeyboardDidShow: undefined, + onKeyboardDidHide: undefined, }); // TODO(ide): Use function refs so we can compose with the scroll From 3b83853713c22ba56ab644815b43b83ac8882f39 Mon Sep 17 00:00:00 2001 From: Bill Fisher Date: Mon, 27 Jul 2015 11:46:56 -0700 Subject: [PATCH 2/3] [ReactNative] fix onMoveShouldSetPanResponderCapture Summary: Typo in implementation prevented onMoveShouldSetPanResponderCapture from working. --- Libraries/vendor/react/browser/eventPlugins/PanResponder.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/vendor/react/browser/eventPlugins/PanResponder.js b/Libraries/vendor/react/browser/eventPlugins/PanResponder.js index b6f0a765a..ed93f88f6 100644 --- a/Libraries/vendor/react/browser/eventPlugins/PanResponder.js +++ b/Libraries/vendor/react/browser/eventPlugins/PanResponder.js @@ -294,7 +294,7 @@ var PanResponder = { return false; } PanResponder._updateGestureStateOnMove(gestureState, touchHistory); - return config.onMoveShouldSetResponderCapture ? + return config.onMoveShouldSetPanResponderCapture ? config.onMoveShouldSetPanResponderCapture(e, gestureState) : false; }, From 3cff9be3d10b0124b096c16707be3589f7558ffc Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Mon, 27 Jul 2015 14:23:44 -0700 Subject: [PATCH 3/3] [ReactNative] Update project template .flowconfig --- Examples/SampleApp/_flowconfig | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Examples/SampleApp/_flowconfig b/Examples/SampleApp/_flowconfig index b2a76e029..8989253d4 100644 --- a/Examples/SampleApp/_flowconfig +++ b/Examples/SampleApp/_flowconfig @@ -9,11 +9,14 @@ # Ignore react-tools where there are overlaps, but don't ignore anything that # react-native relies on -.*/node_modules/react-tools/src/vendor/core/ExecutionEnvironment.js -.*/node_modules/react-tools/src/browser/eventPlugins/ResponderEventPlugin.js -.*/node_modules/react-tools/src/browser/ui/React.js -.*/node_modules/react-tools/src/core/ReactInstanceHandles.js -.*/node_modules/react-tools/src/event/EventPropagators.js +.*/node_modules/react-tools/src/React.js +.*/node_modules/react-tools/src/renderers/shared/reconciler/ReactInstanceHandles.js +.*/node_modules/react-tools/src/renderers/shared/event/EventPropagators.js +.*/node_modules/react-tools/src/renderers/shared/event/eventPlugins/ResponderEventPlugin.js +.*/node_modules/react-tools/src/renderers/shared/event/eventPlugins/ResponderSyntheticEvent.js +.*/node_modules/react-tools/src/renderers/shared/event/eventPlugins/ResponderTouchHistoryStore.js +.*/node_modules/react-tools/src/shared/vendor/core/ExecutionEnvironment.js + # Ignore commoner tests .*/node_modules/commoner/test/.*