status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

BREAKING - Fix unconstraint sizing in main axis 

Summary:
@public
Introduce `overflow:scroll` so that scrolling can be implemented without the current overflow:visible hackiness. Currently we use AT_MOST to measure in the cross axis but not in the main axis. This was done to enable scrolling containers where children are not constraint in the main axis by their parent. This caused problems for non-scrolling containers though as it meant that their children cannot be measured correctly in the main axis. Introducing `overflow:scroll` fixes this.

Reviewed By: astreet

Differential Revision: D3855801
This commit is contained in:
Emil Sjolander 2016-09-14 09:00:26 -07:00 committed by Ahmed El-Helw
parent 57ebb98d19
commit 62756d8be1
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ReactAndroid/src/main/java/com/facebook/react/flat/FlatShadowNode.java
View File

@ -151,9 +151,10 @@ import com.facebook.react.uimanager.ReactClippingViewGroupHelper;
invalidate();
}
@ReactProp(name = "overflow")
public final void setOverflow(String overflow) {
mClipToBounds = "hidden".equals(overflow);
@Override
public void setOverflow(String overflow) {
super.setOverflow(overflow);
mClipToBounds = !"visible".equals(overflow);
if (mClipToBounds) {
mOverflowsContainer = false;
if (mClipRadius > DrawView.MINIMUM_ROUNDED_CLIPPING_VALUE) {