diff --git a/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js b/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js index 2f4410d52..4be589ab7 100644 --- a/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js +++ b/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js @@ -156,7 +156,7 @@ var DrawerLayoutAndroid = React.createClass({ drawerWidth={this.props.drawerWidth} drawerPosition={this.props.drawerPosition} drawerLockMode={this.props.drawerLockMode} - style={styles.base} + style={[styles.base, this.props.style]} onDrawerSlide={this._onDrawerSlide} onDrawerOpen={this._onDrawerOpen} onDrawerClose={this._onDrawerClose} @@ -218,6 +218,7 @@ var DrawerLayoutAndroid = React.createClass({ var styles = StyleSheet.create({ base: { flex: 1, + elevation: 16, }, mainSubview: { position: 'absolute', @@ -230,6 +231,7 @@ var styles = StyleSheet.create({ position: 'absolute', top: 0, bottom: 0, + backgroundColor: 'white', }, }); diff --git a/ReactAndroid/src/main/java/com/facebook/react/processing/ReactPropertyProcessor.java b/ReactAndroid/src/main/java/com/facebook/react/processing/ReactPropertyProcessor.java index bc18bf862..42c5711ba 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/processing/ReactPropertyProcessor.java +++ b/ReactAndroid/src/main/java/com/facebook/react/processing/ReactPropertyProcessor.java @@ -578,7 +578,8 @@ public class ReactPropertyProcessor extends AbstractProcessor { if (checkPropertyExists(name)) { throw new ReactPropertyException( "Module " + mClassName + " has already registered a property named \"" + - name + '"', propertyInfo); + name + "\". If you want to override a property, don't add" + + "the @ReactProp annotation to the property in the subclass", propertyInfo); } mProperties.add(propertyInfo); diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK index 6698d3393..8aea7907e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK @@ -10,6 +10,7 @@ android_library( react_native_target('java/com/facebook/react/uimanager:uimanager'), react_native_target('java/com/facebook/react/uimanager/annotations:annotations'), react_native_target('java/com/facebook/react/views/scroll:scroll'), + react_native_dep('libraries/fbcore/src/main/java/com/facebook/common/logging:logging'), react_native_dep('third-party/java/jsr-305:jsr-305'), react_native_dep('third-party/android/support/v4:lib-support-v4'), ], diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java index 1926c110a..0595d0fd0 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java @@ -11,15 +11,21 @@ package com.facebook.react.views.drawer; import javax.annotation.Nullable; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; import java.util.Map; +import android.os.Build; import android.support.v4.widget.DrawerLayout; import android.view.Gravity; import android.view.View; +import com.facebook.common.logging.FLog; + import com.facebook.react.bridge.JSApplicationIllegalArgumentException; import com.facebook.react.bridge.ReadableArray; import com.facebook.react.common.MapBuilder; +import com.facebook.react.common.ReactConstants; import com.facebook.react.common.SystemClock; import com.facebook.react.uimanager.PixelUtil; import com.facebook.react.uimanager.ThemedReactContext; @@ -89,6 +95,24 @@ public class ReactDrawerLayoutManager extends ViewGroupManager= Build.VERSION_CODES.LOLLIPOP) { + // Facebook is using an older version of the support lib internally that doesn't support + // setDrawerElevation so we invoke it using reflection. + // TODO: Call the method directly when this is no longer needed. + try { + Method method = ReactDrawerLayout.class.getMethod("setDrawerElevation", float.class); + method.invoke(view, PixelUtil.toPixelFromDIP(elevation)); + } catch (Exception ex) { + FLog.w( + ReactConstants.TAG, + "setDrawerElevation is not available in this version of the support lib.", + ex); + } + } + } + @Override public boolean needsCustomLayoutForChildren() { // Return true, since DrawerLayout will lay out it's own children.