From 5d38264f9ea1b0f9eb251874754b59ee5897197e Mon Sep 17 00:00:00 2001 From: Marc Horowitz Date: Fri, 26 Oct 2018 17:04:56 -0700 Subject: [PATCH] Make SystemJSC on macosx actually use the system JSC framework Reviewed By: mzlee Differential Revision: D10475231 fbshipit-source-id: 67f6859cf93aa4fb91c174ee222694271c0d72ed --- ReactCommon/jsi/BUCK | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/ReactCommon/jsi/BUCK b/ReactCommon/jsi/BUCK index 1e216da0b..871ea5981 100644 --- a/ReactCommon/jsi/BUCK +++ b/ReactCommon/jsi/BUCK @@ -69,8 +69,22 @@ rn_xplat_cxx_library( exported_headers = [ "JSCRuntime.h", ], - cxx_deps = [ - "xplat//jsc:jsc", + cxx_exported_platform_linker_flags = [ + ( + "macosx-x86_64", + [ + "-framework", + "JavaScriptCore", + ], + ), + ], + cxx_platform_deps = [ + ( + "^(linux|gcc|platform)", + [ + "xplat//jsc:jsc", + ], + ), ], fbandroid_compiler_flags = [ "-fexceptions",