status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove overflow hidden killswitch 

Summary: There hasn't been any reports of overflow issues since the last issue was fixed in v183 (July 30th). Let's remove this flag

Reviewed By: yungsters

Differential Revision: D10020006

fbshipit-source-id: 593c7d2c2bef5f0bd60d5de1941cd58f7fd6ccc7
This commit is contained in:
Andrew Chen (Eng) 2018-09-25 11:47:11 -07:00 committed by Facebook Github Bot
parent 0a04bb7030
commit 59aada873e
3 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java
View File

@ -112,10 +112,8 @@ public class ReactRootView extends SizeMonitoringFrameLayout
} }
private void init() { private void init() {
if (!ViewProps.sDefaultOverflowHidden) {
setClipChildren(false); setClipChildren(false);
} }
}
@Override @Override
protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) { protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {

5
ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewProps.java
View File

@ -17,11 +17,6 @@ import java.util.HashSet;
*/ */
public class ViewProps { public class ViewProps {
/**
* Kill switch to make overflow hidden by default. This flag will eventually be removed.
*/
public static boolean sDefaultOverflowHidden;
public static final String VIEW_CLASS_NAME = "RCTView"; public static final String VIEW_CLASS_NAME = "RCTView";
// Layout only (only affect positions of children, causes no drawing) // Layout only (only affect positions of children, causes no drawing)

3
ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java
View File

@ -115,10 +115,7 @@ public class ReactViewGroup extends ViewGroup implements
public ReactViewGroup(Context context) { public ReactViewGroup(Context context) {
super(context); super(context);
// TODO: Remove this check after a couple public releases.
if (!ViewProps.sDefaultOverflowHidden) {
setClipChildren(false); setClipChildren(false);
}
mDrawingOrderHelper = new ViewGroupDrawingOrderHelper(this); mDrawingOrderHelper = new ViewGroupDrawingOrderHelper(this);
} }