status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix #14566, image in second code sample not rendering 

Summary:
Fixes #14566, as suggested by hramos. Only change from our convo is that I set the height to 180 in this pull request instead of 240. This to respect the aspect ratio of the source image.

- run website, visit in browser, verify that second example code section renders correctly
- copy and paste example code of second example into the App.js of a freshly created react native app
- prepend "export default" to line 4 of the pasted code
- run the app for ios or android (npm start ios)
- verify that the image of that terrible high-five actually renders in the app now

Closes https://github.com/facebook/react-native/pull/14571

Differential Revision: D5330093

Pulled By: hramos

fbshipit-source-id: a0afcd16d07ac25080af41f9619df0703f11b152
This commit is contained in:
Dirk Stoop 2017-06-27 11:08:40 -07:00 committed by Facebook Github Bot
parent 1a5489bb70
commit 58aca39105
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
website/src/react-native/index.js vendored
View File

@ -95,7 +95,10 @@ class AwkwardScrollingImageWithText extends Component {
render() { render() {
return ( return (
<ScrollView> <ScrollView>
<Image source={{uri: 'https://i.chzbgr.com/full/7345954048/h7E2C65F9/'}} /> <Image
source={{uri: 'https://i.chzbgr.com/full/7345954048/h7E2C65F9/'}}
style={{width: 320, height:180}}
/>
<Text> <Text>
On iOS, a React Native ScrollView uses a native UIScrollView. On iOS, a React Native ScrollView uses a native UIScrollView.
On Android, it uses a native ScrollView. On Android, it uses a native ScrollView.