status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

add markerAnnotation to QPL JS API 

Reviewed By: javache

Differential Revision: D4575107

fbshipit-source-id: 55d2fe86c863d3234ffe9e6520bf3ee96c41012d
This commit is contained in:
Aaron Chiu 2017-02-19 18:10:49 -08:00 committed by Facebook Github Bot
parent 927b356245
commit 555e456754
2 changed files with 46 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ReactAndroid/src/main/java/com/facebook/quicklog/QuickPerformanceLogger.java
View File

@ -85,9 +85,21 @@ public class QuickPerformanceLogger {
String tag) { String tag) {
} }
public void markerAnnotate(
int markerId,
String annotationKey,
String annotationValue) {
}
public void markerAnnotate(
int markerId,
int instanceKey,
String annotationKey,
String annotationValue) {
}
public long currentMonotonicTimestamp() { public long currentMonotonicTimestamp() {
return 0L; return 0L;
} }
} }

33
ReactAndroid/src/main/jni/xreact/jni/JSCPerfLogging.cpp
View File

@ -43,6 +43,20 @@ class JObjectWrapper<jqpl> : public JObjectWrapper<jobject> {
markerTagMethod(this_, markerId, instanceKey, tag); markerTagMethod(this_, markerId, instanceKey, tag);
} }
void markerAnnotate(
int markerId,
int instanceKey,
alias_ref<jstring> key,
alias_ref<jstring> value) {
static auto markerAnnotateMethod =
qplClass()->getMethod<void(
jint,
jint,
alias_ref<jstring>,
alias_ref<jstring>)>("markerAnnotate");
markerAnnotateMethod(this_, markerId, instanceKey, key, value);
}
void markerNote(int markerId, int instanceKey, short actionId, long timestamp) { void markerNote(int markerId, int instanceKey, short actionId, long timestamp) {
static auto markerNoteMethod = static auto markerNoteMethod =
qplClass()->getMethod<void(jint, jint, jshort, jlong)>("markerNote"); qplClass()->getMethod<void(jint, jint, jshort, jlong)>("markerNote");
@ -213,6 +227,24 @@ static JSValueRef nativeQPLMarkerTag(
return JSValueMakeUndefined(ctx); return JSValueMakeUndefined(ctx);
} }
static JSValueRef nativeQPLMarkerAnnotate(
JSContextRef ctx,
JSObjectRef function,
JSObjectRef thisObject,
size_t argumentCount,
const JSValueRef arguments[],
JSValueRef* exception) {
double targets[2];
if (isReady() && grabDoubles(2, targets, ctx, argumentCount, arguments, exception)) {
int32_t markerId = (int32_t) targets[0];
int32_t instanceKey = (int32_t) targets[1];
local_ref<jstring> key = getJStringFromJSValueRef(ctx, arguments[2]);
local_ref<jstring> value = getJStringFromJSValueRef(ctx, arguments[3]);
JQuickPerformanceLoggerProvider::get()->markerAnnotate(markerId, instanceKey, key, value);
}
return JSValueMakeUndefined(ctx);
}
static JSValueRef nativeQPLMarkerNote( static JSValueRef nativeQPLMarkerNote(
JSContextRef ctx, JSContextRef ctx,
JSObjectRef function, JSObjectRef function,
@ -269,6 +301,7 @@ void addNativePerfLoggingHooks(JSGlobalContextRef ctx) {
installGlobalFunction(ctx, "nativeQPLMarkerStart", nativeQPLMarkerStart); installGlobalFunction(ctx, "nativeQPLMarkerStart", nativeQPLMarkerStart);
installGlobalFunction(ctx, "nativeQPLMarkerEnd", nativeQPLMarkerEnd); installGlobalFunction(ctx, "nativeQPLMarkerEnd", nativeQPLMarkerEnd);
installGlobalFunction(ctx, "nativeQPLMarkerTag", nativeQPLMarkerTag); installGlobalFunction(ctx, "nativeQPLMarkerTag", nativeQPLMarkerTag);
installGlobalFunction(ctx, "nativeQPLMarkerAnnotate", nativeQPLMarkerAnnotate);
installGlobalFunction(ctx, "nativeQPLMarkerNote", nativeQPLMarkerNote); installGlobalFunction(ctx, "nativeQPLMarkerNote", nativeQPLMarkerNote);
installGlobalFunction(ctx, "nativeQPLMarkerCancel", nativeQPLMarkerCancel); installGlobalFunction(ctx, "nativeQPLMarkerCancel", nativeQPLMarkerCancel);
installGlobalFunction(ctx, "nativeQPLTimestamp", nativeQPLTimestamp); installGlobalFunction(ctx, "nativeQPLTimestamp", nativeQPLTimestamp);