iOS JSC: Use ICxxExceptionManager to report exception

Reviewed By: shergin

Differential Revision: D7224945

fbshipit-source-id: 8aadbc04c700d6e965be311085d95332571b00b0
This commit is contained in:
Kevin Gozali 2018-03-18 23:49:52 -07:00 committed by Facebook Github Bot
parent f42b5892a1
commit 53a0470b83
2 changed files with 10 additions and 2 deletions

View File

@ -17,6 +17,7 @@ namespace facebook {
namespace react { namespace react {
class FabricUIManager; class FabricUIManager;
class ExceptionManager;
} // namespace react } // namespace react
} // namespace facebook } // namespace facebook
@ -29,6 +30,7 @@ using namespace facebook::react;
@interface RCTFabricUIManagerWrapper : NSObject <RCTInvalidating> @interface RCTFabricUIManagerWrapper : NSObject <RCTInvalidating>
- (std::shared_ptr<FabricUIManager>)manager; - (std::shared_ptr<FabricUIManager>)manager;
- (std::shared_ptr<ExceptionManager>)exceptionManager;
@end @end

View File

@ -7,18 +7,18 @@
#import "RCTFabricUIManagerWrapper.h" #import "RCTFabricUIManagerWrapper.h"
#include <React/RCTCxxExceptionManager.h>
#include <fabric/uimanager/FabricUIManager.h> #include <fabric/uimanager/FabricUIManager.h>
#include <folly/dynamic.h> #include <folly/dynamic.h>
#include <folly/json.h> #include <folly/json.h>
#import "RCTFabricPlatformUIOperationManager.h" #import "RCTFabricPlatformUIOperationManager.h"
// This file contains experimental placeholders, nothing is finalized. // This file contains experimental placeholders, nothing is finalized.
@implementation RCTFabricUIManagerWrapper @implementation RCTFabricUIManagerWrapper
{ {
std::shared_ptr<FabricUIManager> _manager; std::shared_ptr<FabricUIManager> _manager;
std::shared_ptr<ExceptionManager> _exceptionManager;
std::shared_ptr<IFabricPlatformUIOperationManager> _platformUIOperationManager; std::shared_ptr<IFabricPlatformUIOperationManager> _platformUIOperationManager;
} }
@ -26,6 +26,7 @@
{ {
self = [super init]; self = [super init];
if (self) { if (self) {
_exceptionManager = std::make_shared<RCTCxxExceptionManager>();
_platformUIOperationManager = std::make_shared<RCTFabricPlatformUIOperationManagerConnector>(); _platformUIOperationManager = std::make_shared<RCTFabricPlatformUIOperationManagerConnector>();
_manager = std::make_shared<FabricUIManager>(_platformUIOperationManager); _manager = std::make_shared<FabricUIManager>(_platformUIOperationManager);
} }
@ -37,6 +38,11 @@
return _manager; return _manager;
} }
- (std::shared_ptr<ExceptionManager>)exceptionManager
{
return _exceptionManager;
}
- (void)invalidate - (void)invalidate
{ {
} }