status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add no-packager option to run-android and run-ios commands 

Summary:
Currently, while running `react-native run-android` command, React Native's packager is launched, and there is not any way to disable the current behaviour. This is handled somehow on iOS by adding an environment variable `RCT_NO_LAUNCH_PACKAGER` (see #6180).

This is a cross-platform solution that adds the `--no-packager` option both to `run-ios` and `run-android`, which prevents the packager from being launched.

This was tested by building with and without the option, on both environments (Android and iOS) using the device and simulator, working as expected.
Closes https://github.com/facebook/react-native/pull/11735

Differential Revision: D4392170

Pulled By: ericvicenti

fbshipit-source-id: 1c31f109f18715b84cd5ab1b6d5fd758cd0a6efb
This commit is contained in:
joaogranado 2017-01-09 03:25:27 -08:00 committed by Facebook Github Bot
parent 55427566b6
commit 52dea5db64
2 changed files with 29 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
local-cli/runAndroid/runAndroid.js
View File

@ -31,6 +31,10 @@ function runAndroid(argv, config, args) {
return;
}
if (!args.packager) {
return buildAndRun(args);
}
return isPackagerRunning().then(result => {
if (result === 'running') {
console.log(chalk.bold('JS server already running.'));
@ -286,5 +290,8 @@ module.exports = {
command: '--deviceId [string]',
description: 'builds your app and starts it on a specific device/simulator with the ' +
'given device id (listed by running "adb devices" on the command line).',
}, {
command: '--no-packager',
description: 'Do not launch packager while building',
}],
};

31
local-cli/runIOS/runIOS.js
View File

@ -34,7 +34,7 @@ function runIOS(argv, config, args) {
if (args.device) {
const selectedDevice = matchingDevice(devices, args.device);
if (selectedDevice){
return runOnDevice(selectedDevice, scheme, xcodeProject, args.configuration);
return runOnDevice(selectedDevice, scheme, xcodeProject, args.configuration, args.packager);
} else {
if (devices){
console.log('Could not find device with the name: "' + args.device + '".');
@ -54,7 +54,7 @@ function runIOS(argv, config, args) {
function runOnDeviceByUdid(args, scheme, xcodeProject, devices) {
const selectedDevice = matchingDeviceByUdid(devices, args.udid);
if (selectedDevice){
return runOnDevice(selectedDevice, scheme, xcodeProject, args.configuration);
return runOnDevice(selectedDevice, scheme, xcodeProject, args.configuration, args.packager);
} else {
if (devices){
console.log('Could not find device with the udid: "' + args.udid + '".');
@ -91,7 +91,7 @@ function runOnSimulator(xcodeProject, args, inferredSchemeName, scheme){
}
resolve(selectedSimulator.udid)
})
.then((udid) => buildProject(xcodeProject, udid, scheme, args.configuration))
.then((udid) => buildProject(xcodeProject, udid, scheme, args.configuration, args.packager))
.then((appName) => {
if (!appName) {
appName = inferredSchemeName;
@ -111,8 +111,8 @@ function runOnSimulator(xcodeProject, args, inferredSchemeName, scheme){
})
}
function runOnDevice(selectedDevice, scheme, xcodeProject, configuration){
return buildProject(xcodeProject, selectedDevice.udid, scheme, configuration)
function runOnDevice(selectedDevice, scheme, xcodeProject, configuration, launchPackager) {
return buildProject(xcodeProject, selectedDevice.udid, scheme, configuration, launchPackager)
.then((appName) => {
if (!appName) {
appName = scheme;
@ -135,7 +135,7 @@ function runOnDevice(selectedDevice, scheme, xcodeProject, configuration){
});
}
function buildProject(xcodeProject, udid, scheme, configuration = 'Debug') {
function buildProject(xcodeProject, udid, scheme, configuration = 'Debug', launchPackager = false) {
return new Promise((resolve,reject) =>
{
var xcodebuildArgs = [
@ -146,7 +146,7 @@ function buildProject(xcodeProject, udid, scheme, configuration = 'Debug') {
'-derivedDataPath', 'build',
];
console.log(`Building using "xcodebuild ${xcodebuildArgs.join(' ')}"`);
const buildProcess = child_process.spawn('xcodebuild', xcodebuildArgs);
const buildProcess = child_process.spawn('xcodebuild', xcodebuildArgs, getProcessOptions(launchPackager));
let buildOutput = "";
buildProcess.stdout.on('data', function(data) {
console.log(data.toString());
@ -197,6 +197,16 @@ function printFoundDevices(devices){
}
}
function getProcessOptions(launchPackager) {
if (launchPackager) {
return {};
}
return {
env: Object.assign({}, process.env, { RCT_NO_LAUNCH_PACKAGER: true }),
};
}
module.exports = {
name: 'run-ios',
description: 'builds your app and starts it on iOS simulator',
@ -233,8 +243,11 @@ module.exports = {
}, {
command: '--device [string]',
description: 'Explicitly set device to use by name. The value is not required if you have a single device connected.',
},{
}, {
command: '--udid [string]',
description: 'Explicitly set device to use by udid',
}]
}, {
command: '--no-packager',
description: 'Do not launch packager while building',
}],
};