status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Forcing to `alignSelf: stretch` was removed from <TextInput> 

Summary:
Because it introduces inconsistency in RN layout model, confuses people and hurts dev experience.
The original problem was introduced in D1611014 as an attempt to address the intrinsic size issue.
So, now <TextInput> has intrinsic size (D5069971) and we don't need this hack anymore.

GH issues:
https://github.com/facebook/react-native/issues/11892
https://github.com/facebook/react-native/issues/9646

Reviewed By: javache

Differential Revision: D5072833

fbshipit-source-id: d9a60ab09b728e6de89bfa53eda07069377f1369
This commit is contained in:
Valentin Shergin 2017-05-29 15:56:44 -07:00 committed by Facebook Github Bot
parent 44af4d19d3
commit 4e40521620
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/Components/TextInput/TextInput.js
View File

@ -628,7 +628,7 @@ const TextInput = React.createClass({
var textContainer;
var props = Object.assign({}, this.props);
props.style = [styles.input, this.props.style];
props.style = [this.props.style];
if (props.selection && props.selection.end == null) {
props.selection = {start: props.selection.start, end: props.selection.start};
@ -859,9 +859,6 @@ const TextInput = React.createClass({
});
var styles = StyleSheet.create({
input: {
alignSelf: 'stretch',
},
multilineInput: {
// This default top inset makes RCTTextView seem as close as possible
// to single-line RCTTextField defaults, using the system defaults