From 4e1f2f4e0f70c78ed6009d288e3820a86a3df3cb Mon Sep 17 00:00:00 2001 From: Pawel Sienkowski Date: Thu, 5 Nov 2015 08:16:05 -0800 Subject: [PATCH] Fixed: Move out setupDevtools call from renderApplication function Reviewed By: sahrens Differential Revision: D2620876 fb-gh-sync-id: 8971a1c523c06966dd11280e19272429aa3f9c8d --- .../Initialization/InitializeJavaScriptAppEngine.js | 9 +++++++++ Libraries/ReactIOS/renderApplication.ios.js | 4 ---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/Libraries/JavaScriptAppEngine/Initialization/InitializeJavaScriptAppEngine.js b/Libraries/JavaScriptAppEngine/Initialization/InitializeJavaScriptAppEngine.js index 93e97e60b..b3de8921e 100644 --- a/Libraries/JavaScriptAppEngine/Initialization/InitializeJavaScriptAppEngine.js +++ b/Libraries/JavaScriptAppEngine/Initialization/InitializeJavaScriptAppEngine.js @@ -178,6 +178,14 @@ function setUpNumber() { Number.MIN_SAFE_INTEGER = Number.MIN_SAFE_INTEGER || -(Math.pow(2, 53) - 1); } +function setUpDevTools() { + // not when debugging in chrome + if (__DEV__ && !window.document && require('Platform').OS === 'ios') { + var setupDevtools = require('setupDevtools'); + setupDevtools(); + } +} + setUpProcessEnv(); setUpRedBoxErrorHandler(); setUpTimers(); @@ -190,6 +198,7 @@ setUpWebSockets(); setUpProfile(); setUpFlowChecker(); setUpNumber(); +setUpDevTools(); // Just to make sure the JS gets packaged up. Wait until the JS environment has // been initialized before requiring them. diff --git a/Libraries/ReactIOS/renderApplication.ios.js b/Libraries/ReactIOS/renderApplication.ios.js index 0bf7fba0e..aca645324 100644 --- a/Libraries/ReactIOS/renderApplication.ios.js +++ b/Libraries/ReactIOS/renderApplication.ios.js @@ -69,10 +69,6 @@ function renderApplication( rootTag, 'Expect to have a valid rootTag, instead got ', rootTag ); - if (__DEV__ && !window.document) { - var setupDevtools = require('setupDevtools'); - setupDevtools(); - } React.render(