From 4d9f02f56842389adee89fd9711822cc16d174e8 Mon Sep 17 00:00:00 2001 From: Taras Tsugrii Date: Thu, 20 Dec 2018 11:14:13 -0800 Subject: [PATCH] Do not use glob for static paths. Summary: ``` >>> Lint for xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/react/uimanager/BUCK: Warning (BUILDIFIERLINT2) constant-glob Glob pattern `DisplayMetricsHolder.java` has no wildcard ('*'). Constant patterns can be error-prone, move the file outside the glob. (https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#constant-glob) 50 rn_android_library( 51 name = "DisplayMetrics", 52 srcs = glob([ >>> 53 "DisplayMetricsHolder.java", 54 ]), 55 required_for_source_only_abi = True, 56 visibility = [ ``` Reviewed By: hramos Differential Revision: D13519693 fbshipit-source-id: 1cb9721f541c22480e4dbdad03978092453b42ba --- ReactAndroid/src/main/java/com/facebook/react/uimanager/BUCK | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BUCK b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BUCK index 9bb553e2e..918b486a3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BUCK @@ -49,9 +49,9 @@ rn_android_library( rn_android_library( name = "DisplayMetrics", - srcs = glob([ + srcs = [ "DisplayMetricsHolder.java", - ]), + ], required_for_source_only_abi = True, visibility = [ "PUBLIC",