From 4b70c66a277a49fffd52e47f2c2b16770b992676 Mon Sep 17 00:00:00 2001
From: Pieter De Baets <pieterdb@fb.com>
Date: Fri, 30 Sep 2016 09:27:50 -0700
Subject: [PATCH] Use glob in cxxreact BUCK rule

Reviewed By: lexs

Differential Revision: D3944546

fbshipit-source-id: 73cb3eeff3b3f5f543e69893f5071c4bd3e78be4
---
 ReactCommon/cxxreact/BUCK | 77 +++++++++++++--------------------------
 1 file changed, 26 insertions(+), 51 deletions(-)

diff --git a/ReactCommon/cxxreact/BUCK b/ReactCommon/cxxreact/BUCK
index 09acf8373..19aaada22 100644
--- a/ReactCommon/cxxreact/BUCK
+++ b/ReactCommon/cxxreact/BUCK
@@ -106,61 +106,36 @@ cxx_library(
   ],
 )
 
+CXXREACT_PUBLIC_HEADERS = [
+  'CxxMessageQueue.h',
+  'CxxNativeModule.h',
+  'Executor.h',
+  'ExecutorToken.h',
+  'ExecutorTokenFactory.h',
+  'Instance.h',
+  'JSCExecutor.h',
+  'JSCHelpers.h',
+  'JSCWebWorker.h',
+  'JSModulesUnbundle.h',
+  'MessageQueueThread.h',
+  'MethodCall.h',
+  'ModuleRegistry.h',
+  'NativeModule.h',
+  'NativeToJsBridge.h',
+  'noncopyable.h',
+  'Platform.h',
+  'SystraceSection.h',
+  'Unicode.h',
+  'Value.h',
+]
+
 react_library(
   soname = 'libreactnativefb.so',
   header_namespace = 'cxxreact',
   force_static = True,
-  srcs = [
-    'CxxMessageQueue.cpp',
-    'CxxNativeModule.cpp',
-    'Executor.cpp',
-    'Instance.cpp',
-    'JSCExecutor.cpp',
-    'JSCHelpers.cpp',
-    'JSCLegacyProfiler.cpp',
-    'JSCLegacyTracing.cpp',
-    'JSCMemory.cpp',
-    'JSCPerfStats.cpp',
-    'JSCSamplingProfiler.cpp',
-    'JSCTracing.cpp',
-    'JSCWebWorker.cpp',
-    'MethodCall.cpp',
-    'ModuleRegistry.cpp',
-    'NativeToJsBridge.cpp',
-    'Platform.cpp',
-    'Value.cpp',
-    'Unicode.cpp',
-  ],
-  headers = [
-    'JSCLegacyProfiler.h',
-    'JSCLegacyTracing.h',
-    'JSCMemory.h',
-    'JSCPerfStats.h',
-    'JSCSamplingProfiler.h',
-    'JSCTracing.h',
-  ],
-  exported_headers = [
-    'CxxMessageQueue.h',
-    'CxxNativeModule.h',
-    'Executor.h',
-    'ExecutorToken.h',
-    'ExecutorTokenFactory.h',
-    'Instance.h',
-    'JSCExecutor.h',
-    'JSCHelpers.h',
-    'JSCWebWorker.h',
-    'JSModulesUnbundle.h',
-    'MessageQueueThread.h',
-    'MethodCall.h',
-    'ModuleRegistry.h',
-    'NativeModule.h',
-    'NativeToJsBridge.h',
-    'noncopyable.h',
-    'Platform.h',
-    'SystraceSection.h',
-    'Value.h',
-    'Unicode.h',
-  ],
+  srcs = glob(['*.cpp']),
+  headers = glob(['*.h'], excludes=CXXREACT_PUBLIC_HEADERS),
+  exported_headers = CXXREACT_PUBLIC_HEADERS,
   preprocessor_flags = [
     '-DLOG_TAG="ReactNative"',
     '-DWITH_FBSYSTRACE=1',