status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-03-01 01:20:31 +00:00
Code Issues Projects Releases Wiki Activity

Change "Hide/Show" Inspector to "Toggle"

Browse Source 
Summary:The JS and native state can get out of sync if you reload JS while inspecting, so don't even bother trying on
native.

Reviewed By: lexs

Differential Revision: D3203020

fb-gh-sync-id: a3b7294bb0c28c0508f508be53d3ef895a7195b0
fbshipit-source-id: a3b7294bb0c28c0508f508be53d3ef895a7195b0
This commit is contained in:
Spencer Ahrens 2016-04-21 16:56:07 -07:00 committed by Facebook Github Bot 2
parent 91dcc9ac8e
commit 47dff23fe4
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java
View File

@ -296,9 +296,7 @@ public class DevSupportManagerImpl implements DevSupportManager {
}
});
options.put(
mDevSettings.isElementInspectorEnabled()
? mApplicationContext.getString(R.string.catalyst_element_inspector_off)
: mApplicationContext.getString(R.string.catalyst_element_inspector),
mApplicationContext.getString(R.string.catalyst_element_inspector),
new DevOptionHandler() {
@Override
public void onOptionSelected() {

2
ReactAndroid/src/main/res/devsupport/values-en-rGB/strings.xml
View File

@ -12,5 +12,5 @@
<string name="catalyst_jsload_title">Please wait...</string>
<string name="catalyst_jsload_message">Fetching JS bundle</string>
<string name="catalyst_jsload_error">Unable to download JS bundle</string>
<string name="catalyst_element_inspector">Show Inspector</string>
<string name="catalyst_element_inspector">Toggle Inspector</string>
</resources>

3
ReactAndroid/src/main/res/devsupport/values/strings.xml
View File

@ -16,8 +16,7 @@
<string name="catalyst_jsload_error" project="catalyst" translatable="false">Unable to download JS bundle. Did you forget to start the development server or connect your device?</string>
<string name="catalyst_remotedbg_message" project="catalyst" translatable="false">Connecting to remote debugger</string>
<string name="catalyst_remotedbg_error" project="catalyst" translatable="false">Unable to connect with remote debugger</string>
<string name="catalyst_element_inspector" project="catalyst" translatable="false">Show Inspector</string>
<string name="catalyst_element_inspector_off" project="catalyst" translatable="false">Hide Inspector</string>
<string name="catalyst_element_inspector" project="catalyst" translatable="false">Toggle Inspector</string>
<string name="catalyst_start_profile" project="catalyst" translatable="false">Start Profile</string>
<string name="catalyst_stop_profile" project="catalyst" translatable="false">Stop Profile</string>
</resources>