From 4391ef218b5145fb04103e260f862f968f653063 Mon Sep 17 00:00:00 2001 From: Martin Konicek Date: Wed, 1 Jun 2016 04:01:45 -0700 Subject: [PATCH] Tweak dev menu label: Stop Remote JS Debugging Summary: "Stop" is a bit clearer - the debugger is started and stopped, rather than enabled / disabled. Small difference :) In contrast, live reloading and hot reloading are enabled and disabled. satya164 pointed it out in [this comment](https://github.com/facebook/react-native/commit/31eea8eee3bd904065b06c639321dbc2cea1ca55#commitcomment-17682563) and I agree. **Test Plan** Ran the UIExplorer: screen shot 2016-05-31 at 11 11 28 pm On Android the change is kind of obvious :) Closes https://github.com/facebook/react-native/pull/7861 Differential Revision: D3371207 Pulled By: mkonicek fbshipit-source-id: 769288f687a98d62cf5c1a22cbc857b7dc4acf00 --- React/Modules/RCTDevMenu.m | 2 +- ReactAndroid/src/main/res/devsupport/values/strings.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/React/Modules/RCTDevMenu.m b/React/Modules/RCTDevMenu.m index f574f7b06..d7cbc5dc5 100644 --- a/React/Modules/RCTDevMenu.m +++ b/React/Modules/RCTDevMenu.m @@ -466,7 +466,7 @@ RCT_EXPORT_MODULE() } else { BOOL isDebuggingJS = _executorClass && _executorClass == jsDebuggingExecutorClass; NSString *debuggingDescription = [_defaults objectForKey:@"websocket-executor-name"] ?: @"Remote JS"; - NSString *debugTitleJS = isDebuggingJS ? [NSString stringWithFormat:@"Disable %@ Debugging", debuggingDescription] : [NSString stringWithFormat:@"Debug %@", _webSocketExecutorName]; + NSString *debugTitleJS = isDebuggingJS ? [NSString stringWithFormat:@"Stop %@ Debugging", debuggingDescription] : [NSString stringWithFormat:@"Debug %@", _webSocketExecutorName]; [items addObject:[RCTDevMenuItem buttonItemWithTitle:debugTitleJS handler:^{ weakSelf.executorClass = isDebuggingJS ? Nil : jsDebuggingExecutorClass; }]]; diff --git a/ReactAndroid/src/main/res/devsupport/values/strings.xml b/ReactAndroid/src/main/res/devsupport/values/strings.xml index dda73a8c5..edf2669c1 100644 --- a/ReactAndroid/src/main/res/devsupport/values/strings.xml +++ b/ReactAndroid/src/main/res/devsupport/values/strings.xml @@ -2,7 +2,7 @@ Reload Debug JS Remotely - Disable Remote JS Debugging + Stop Remote JS Debugging Enable Hot Reloading Disable Hot Reloading Enable Live Reload