From 40b17926bb2c724f1580b2eb0c30a37f5d48030a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= Date: Thu, 8 Feb 2018 15:50:25 -0800 Subject: [PATCH] Move approval to separate deploy workflow Summary: Closes https://github.com/facebook/react-native/pull/17916 Differential Revision: D6943605 Pulled By: hramos fbshipit-source-id: 0e86f01aa38c15e5bc179c5e517f079eb34d495f --- .circleci/config.yml | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 14b96565a..b6d37a3ed 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -537,7 +537,7 @@ jobs: workflows: version: 2 - build: + test: jobs: # Checkout repo and run Yarn @@ -581,16 +581,19 @@ workflows: filters: *filter-ignore-gh-pages requires: - checkout_code - - # If we are on a stable branch, deploy to `npm` + + # Run code checks + - analyze_pr: + filters: *filter-ignore-master-stable + requires: + - checkout_code + + deploy: + jobs: + # If we are on a stable branch, wait for approval to deploy to npm - approve_publish_npm_package: + filters: *filter-only-stable type: approval - publish_npm_package: - filters: *filter-only-stable requires: - approve_publish_npm_package - - - analyze_pr: - filters: *filter-ignore-master-stable - requires: - - checkout_code \ No newline at end of file