Fix react-native function call arity errors

Reviewed By: zertosh

Differential Revision: D5081816

fbshipit-source-id: 5978770c30a69fb287d03aa7511999ce30f856a1

IntegrationTests/LayoutEventsTest.js

@@ -24,7 +24,7 @@ var { TestModule } = ReactNative.NativeModules;
 
 var deepDiffer = require('deepDiffer');
 
-function debug() {
+function debug(...args) {
   // console.log.apply(null, arguments);
 }
 

Libraries/Experimental/WindowedListView.js

@@ -73,11 +73,15 @@ type Props = {
   /**
    * Rendered when the list is scrolled faster than rows can be rendered.
    */
-  renderWindowBoundaryIndicator?: () => ?React.Element<any>,
+  renderWindowBoundaryIndicator?: (
+    showIndicator: boolean,
+  ) => ?React.Element<any>,
   /**
    * Always rendered at the bottom of all the rows.
    */
-  renderFooter?: () => ?React.Element<any>,
+  renderFooter?: (
+    showFooter: boolean,
+  ) => ?React.Element<any>,
   /**
    * Pipes through normal onScroll events from the underlying `ScrollView`.
    */

Libraries/Lists/MetroListView.js

@@ -68,7 +68,13 @@ class MetroListView extends React.Component {
   scrollToItem(params: {animated?: ?boolean, item: Item, viewPosition?: number}) {
     throw new Error('scrollToItem not supported in legacy ListView.');
   }
-  scrollToLocation() {
+  scrollToLocation(params: {
+    animated?: ?boolean,
+    itemIndex: number,
+    sectionIndex: number,
+    viewOffset?: number,
+    viewPosition?: number,
+  }) {
     throw new Error('scrollToLocation not supported in legacy ListView.');
   }
   scrollToOffset(params: {animated?: ?boolean, offset: number}) {

Libraries/Lists/VirtualizedSectionList.js

@@ -40,7 +40,7 @@ type SectionBase = {
     },
   }) => ?React.Element<*>,
   ItemSeparatorComponent?: ?ReactClass<*>,
-  keyExtractor?: (item: SectionItem) => string,
+  keyExtractor?: (item: SectionItem, index: ?number) => string,
 
   // TODO: support more optional/override props
   // FooterComponent?: ?ReactClass<*>,

Libraries/Renderer/src/renderers/shared/fiber/ReactChildFiber.js

@@ -60,7 +60,7 @@ if (__DEV__) {
       'Each child in an array or iterator should have a unique ' +
       '"key" prop. See https://fb.me/react-warning-keys for ' +
       'more information.' +
-      (getCurrentFiberStackAddendum(child) || '');
+      (getCurrentFiberStackAddendum() || '');
     if (ownerHasKeyUseWarning[currentComponentErrorInfo]) {
       return;
     }
@@ -71,7 +71,7 @@ if (__DEV__) {
       'Each child in an array or iterator should have a unique ' +
         '"key" prop. See https://fb.me/react-warning-keys for ' +
         'more information.%s',
-      getCurrentFiberStackAddendum(child),
+      getCurrentFiberStackAddendum(),
     );
   };
 }

Libraries/Renderer/src/renderers/shared/fiber/ReactFiberErrorLogger.js

@@ -16,7 +16,7 @@ const invariant = require('fbjs/lib/invariant');
 
 import type {CapturedError} from 'ReactFiberScheduler';
 
-const defaultShowDialog = () => true;
+const defaultShowDialog = (capturedError: CapturedError) => true;
 
 let showDialog = defaultShowDialog;
 

Libraries/Renderer/src/renderers/shared/fiber/ReactFiberReconciler.js

@@ -49,7 +49,7 @@ type OpaqueRoot = FiberRoot;
 
 export type HostConfig<T, P, I, TI, PI, C, CX, PL> = {
   getRootHostContext(rootContainerInstance: C): CX,
-  getChildHostContext(parentHostContext: CX, type: T): CX,
+  getChildHostContext(parentHostContext: CX, type: T, instance: C): CX,
   getPublicInstance(instance: I | TI): PI,
 
   createInstance(

Libraries/Renderer/src/renderers/shared/fiber/ReactFiberScheduler.js

@@ -452,7 +452,7 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
       firstEffect = finishedWork.firstEffect;
     }
 
-    const commitInfo = prepareForCommit();
+    prepareForCommit();
 
     // Commit all the side-effects within a tree. We'll do this in two passes.
     // The first pass performs all the host insertions, updates, deletions and
@@ -468,11 +468,10 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
           null,
           commitAllHostEffects,
           null,
-          finishedWork,
         );
       } else {
         try {
-          commitAllHostEffects(finishedWork);
+          commitAllHostEffects();
         } catch (e) {
           error = e;
         }
@@ -494,7 +493,7 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
       stopCommitHostEffectsTimer();
     }
 
-    resetAfterCommit(commitInfo);
+    resetAfterCommit();
 
     // The work-in-progress tree is now the current tree. This must come after
     // the first pass of the commit phase, so that the previous tree is still
@@ -517,11 +516,10 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
           null,
           commitAllLifeCycles,
           null,
-          finishedWork,
         );
       } else {
         try {
-          commitAllLifeCycles(finishedWork);
+          commitAllLifeCycles();
         } catch (e) {
           error = e;
         }

Libraries/Renderer/src/renderers/shared/stack/reconciler/CallbackQueue.js

@@ -28,10 +28,10 @@ var validateCallback = require('validateCallback');
  * @implements PooledClass
  * @internal
  */
-class CallbackQueue<T> {
+class CallbackQueue<T, Targ> {
-  _callbacks: ?Array<() => void>;
+  _callbacks: ?Array<(arg: Targ) => void>;
   _contexts: ?Array<T>;
-  _arg: ?mixed;
+  _arg: Targ;
 
   constructor(arg) {
     this._callbacks = null;

Libraries/Renderer/src/shared/utils/PooledClass.js

@@ -95,8 +95,8 @@ var addPoolingTo = function<T>(
   CopyConstructor: Class<T>,
   pooler: Pooler,
 ): Class<T> & {
-  getPooled(): /* arguments of the constructor */ T,
+  getPooled(...args: $ReadOnlyArray<mixed>): /* arguments of the constructor */ T,
-  release(): void,
+  release(instance: mixed): void,
 } {
   // Casting as any so that flow ignores the actual implementation and trusts
   // it to match the type we declared

Libraries/Utilities/logError.js

@@ -16,12 +16,12 @@
  * `console.error` as a failure callback - it's not properly bound.  If passes an
  * `Error` object, it will print the message and stack.
  */
-var logError = function() {
+var logError = function(...args: $ReadOnlyArray<mixed>) {
-  if (arguments.length === 1 && arguments[0] instanceof Error) {
+  if (args.length === 1 && args[0] instanceof Error) {
-    var err = arguments[0];
+    var err = args[0];
     console.error('Error: "' + err.message + '".  Stack:\n' + err.stack);
   } else {
-    console.error.apply(console, arguments);
+    console.error.apply(console, args);
   }
 };
 

flow/console.js

@@ -26,6 +26,7 @@ declare module 'console' {
   declare function trace(first: any, ...rest: any): void;
   declare function warn(...data: any): void;
   declare class Console {
+    constructor(stdout: stream$Writable, stdin?: stream$Writable): void;
     assert(value: any, ...message: any): void,
     dir(
       obj: Object,

local-cli/bundle/output/bundle.js

@@ -43,7 +43,7 @@ function createCodeWithMap(bundle: Bundle, dev: boolean, sourceMapSourcesRoot?:
 function saveBundleAndMap(
   bundle: Bundle,
   options: OutputOptions,
-  log: (x: string) => {},
+  log: (...args: Array<string>) => {},
 ): Promise<> {
   const {
     bundleOutput,

local-cli/bundle/output/unbundle/as-assets.js

@@ -38,7 +38,7 @@ const MODULES_DIR = 'js-modules';
 function saveAsAssets(
   bundle: Bundle,
   options: OutputOptions,
-  log: (x: string) => void,
+  log: (...args: Array<string>) => void,
 ): Promise<mixed> {
   const {
     bundleOutput,

local-cli/bundle/output/unbundle/as-indexed-file.js

@@ -34,7 +34,7 @@ const SIZEOF_UINT32 = 4;
 function saveAsIndexedFile(
   bundle: Bundle,
   options: OutputOptions,
-  log: (x: string) => void,
+  log: (...args: Array<string>) => void,
 ): Promise<> {
   const {
     bundleOutput,

local-cli/bundle/output/unbundle/write-sourcemap.js

@@ -15,7 +15,7 @@ const writeFile = require('../writeFile');
 function writeSourcemap(
   fileName: string,
   contents: string,
-  log: (x: string) => void,
+  log: (...args: Array<string>) => void,
 ): Promise<> {
   if (!fileName) {
     return Promise.resolve();

packager/src/Bundler/index.js

@@ -14,6 +14,7 @@
 const assert = require('assert');
 const crypto = require('crypto');
 const debug = require('debug')('RNP:Bundler');
+const emptyFunction = require('fbjs/lib/emptyFunction');
 const fs = require('fs');
 const Transformer = require('../JSTransformer');
 const Resolver = require('../Resolver');
@@ -89,8 +90,6 @@ export type ExtendedAssetDescriptor = AssetDescriptor & {
 
 const sizeOf = denodeify(imageSize);
 
-const noop = () => {};
-
 const {
   createActionStartEntry,
   createActionEndEntry,
@@ -173,7 +172,7 @@ class Bundler {
 
     this._getModuleId = createModuleIdFactory();
 
-    let getCacheKey = () => '';
+    let getCacheKey = (options: mixed) => '';
     if (opts.transformModulePath) {
       /* $FlowFixMe: dynamic requires prevent static typing :'(  */
       const transformer = require(opts.transformModulePath);
@@ -283,7 +282,7 @@ class Bundler {
     const matchingRoot = this._projectRoots.find(root => filePath.startsWith(root));
 
     if (!matchingRoot) {
-      throw new Error('No matching project root for ', filePath);
+      throw new Error('No matching project root for ' + filePath);
     }
 
     // Replaces '\' with '/' for Windows paths.
@@ -422,10 +421,10 @@ class Bundler {
     isolateModuleIDs,
     generateSourceMaps,
     assetPlugins,
-    onResolutionResponse = noop,
+    onResolutionResponse = emptyFunction,
-    onModuleTransformed = noop,
+    onModuleTransformed = emptyFunction,
-    finalizeBundle = noop,
+    finalizeBundle = emptyFunction,
-    onProgress = noop,
+    onProgress = emptyFunction,
   }: *) {
     const transformingFilesLogEntry =
       log(createActionStartEntry({
@@ -641,7 +640,7 @@ class Bundler {
     bundle: Bundle,
     entryFilePath: string,
     options: BundlingOptions,
-    getModuleId: () => number,
+    getModuleId: (module: Module) => number,
     dependencyPairs: Array<[string, Module]>,
     assetPlugins: Array<string>,
   }): Promise<ModuleTransport> {

packager/src/JSTransformer/index.js

@@ -166,11 +166,11 @@ function TransformError() {
 }
 util.inherits(TransformError, SyntaxError);
 
-function formatError(err, filename, source) {
+function formatError(err, filename) {
   if (err.loc) {
-    return formatBabelError(err, filename, source);
+    return formatBabelError(err, filename);
   } else {
-    return formatGenericError(err, filename, source);
+    return formatGenericError(err, filename);
   }
 }
 

packager/src/ModuleGraph/Graph.js

@@ -10,6 +10,7 @@
  */
 'use strict';
 
+const emptyFunction = require('fbjs/lib/emptyFunction');
 const invariant = require('fbjs/lib/invariant');
 const memoize = require('async/memoize');
 const nullthrows = require('fbjs/lib/nullthrows');
@@ -51,11 +52,10 @@ type LoadQueue =
 const createParentModule =
   () => ({file: {code: '', type: 'script', path: ''}, dependencies: []});
 
-const noop = () => {};
 const NO_OPTIONS = {};
 
 exports.create = function create(resolve: ResolveFn, load: LoadFn): GraphFn {
-  function Graph(entryPoints, platform, options, callback = noop) {
+  function Graph(entryPoints, platform, options, callback = emptyFunction) {
     const {
       log = (console: any),
       optimize = false,
@@ -80,7 +80,7 @@ exports.create = function create(resolve: ResolveFn, load: LoadFn): GraphFn {
       callback(null, collect());
     };
     loadQueue.error = error => {
-      loadQueue.error = noop;
+      loadQueue.error = emptyFunction;
       loadQueue.kill();
       callback(error);
     };

packager/src/Server/index.js

@@ -16,6 +16,7 @@ const Bundler = require('../Bundler');
 const MultipartResponse = require('./MultipartResponse');
 
 const defaults = require('../../defaults');
+const emptyFunction = require('fbjs/lib/emptyFunction');
 const mime = require('mime-types');
 const parsePlatformFilePath = require('../node-haste/lib/parsePlatformFilePath');
 const path = require('path');
@@ -26,7 +27,6 @@ const url = require('url');
 const debug = require('debug')('RNP:Server');
 
 import type Module, {HasteImpl} from '../node-haste/Module';
-import type {Stats} from 'fs';
 import type {IncomingMessage, ServerResponse} from 'http';
 import type ResolutionResponse from '../node-haste/DependencyGraph/ResolutionResponse';
 import type Bundle from '../Bundler/Bundle';
@@ -175,7 +175,7 @@ class Server {
       watch: options.watch || false,
     };
     const processFileChange =
-      ({type, filePath, stat}) => this.onFileChange(type, filePath, stat);
+      ({type, filePath}) => this.onFileChange(type, filePath);
 
     this._reporter = options.reporter;
     this._projectRoots = this._opts.projectRoots;
@@ -316,8 +316,8 @@ class Server {
     });
   }
 
-  onFileChange(type: string, filePath: string, stat: Stats) {
+  onFileChange(type: string, filePath: string) {
-    this._assetServer.onFileChange(type, filePath, stat);
+    this._assetServer.onFileChange(type, filePath);
 
     // If Hot Loading is enabled avoid rebuilding bundles and sending live
     // updates. Instead, send the HMR updates right away and clear the bundles
@@ -653,7 +653,7 @@ class Server {
         entry_point: options.entryFile,
       }));
 
-    let reportProgress = () => {};
+    let reportProgress = emptyFunction;
     if (!this._opts.silent) {
       reportProgress = (transformedFileCount, totalFileCount) => {
         this._reporter.update({

packager/src/lib/TransformCache.js

@@ -90,14 +90,16 @@ class TransformCache {
    * close to each others, one of the workers is going to loose its results no
    * matter what.
    */
-  writeSync(props: {
+  writeSync(
-    filePath: string,
+    props: {
-    sourceCode: string,
+      filePath: string,
-    getTransformCacheKey: GetTransformCacheKey,
+      sourceCode: string,
-    transformOptions: WorkerOptions,
+      getTransformCacheKey: GetTransformCacheKey,
-    transformOptionsKey: string,
+      transformOptions: WorkerOptions,
-    result: CachedResult,
+      transformOptionsKey: string,
-  }): void {
+      result: CachedResult,
+    },
+  ): void {
     const cacheFilePath = this._getCacheFilePaths(props);
     mkdirp.sync(path.dirname(cacheFilePath.transformedCode));
     const {result} = props;
@@ -233,7 +235,7 @@ class TransformCache {
     mkdirp.sync(cacheDirPath);
     const cacheCollectionFilePath = path.join(cacheDirPath, 'last_collected');
     const lastCollected = Number.parseInt(
-      tryReadFileSync(cacheCollectionFilePath, 'utf8'),
+      tryReadFileSync(cacheCollectionFilePath),
       10,
     );
     if (
@@ -253,10 +255,12 @@ class TransformCache {
    * account because it would generate lots of file during development. (The
    * source hash is stored in the metadata instead).
    */
-  _getCacheFilePaths(props: {
+  _getCacheFilePaths(
-    filePath: string,
+    props: {
-    transformOptionsKey: string,
+      filePath: string,
-  }): CacheFilePaths {
+      transformOptionsKey: string,
+    },
+  ): CacheFilePaths {
     const hasher = crypto
       .createHash('sha1')
       .update(props.filePath)
@@ -384,13 +388,15 @@ function tryParseJSON(str: string): any {
   }
 }
 
-function hashSourceCode(props: {
+function hashSourceCode(
-  filePath: string,
+  props: {
-  sourceCode: string,
+    filePath: string,
-  getTransformCacheKey: GetTransformCacheKey,
+    sourceCode: string,
-  transformOptions: WorkerOptions,
+    getTransformCacheKey: GetTransformCacheKey,
-  transformOptionsKey: string,
+    transformOptions: WorkerOptions,
-}): string {
+    transformOptionsKey: string,
+  },
+): string {
   return crypto
     .createHash('sha1')
     .update(props.getTransformCacheKey(props.transformOptions))

packager/src/node-haste/DependencyGraph.js

@@ -156,8 +156,8 @@ class DependencyGraph extends EventEmitter {
     this._filesByDirNameIndex = new FilesByDirNameIndex(hasteFS.getAllFiles());
     this._assetResolutionCache.clear();
     this._moduleMap = moduleMap;
-    eventsQueue.forEach(({type, filePath, stat}) =>
+    eventsQueue.forEach(({type, filePath}) =>
-      this._moduleCache.processFileChange(type, filePath, stat)
+      this._moduleCache.processFileChange(type, filePath)
     );
     this.emit('change');
   }
@@ -290,11 +290,11 @@ class DependencyGraph extends EventEmitter {
 
 }
 
-function NotFoundError() {
+function NotFoundError(...args) {
   /* $FlowFixMe: monkey-patching */
   Error.call(this);
   Error.captureStackTrace(this, this.constructor);
-  var msg = util.format.apply(util, arguments);
+  var msg = util.format.apply(util, args);
   this.message = msg;
   this.type = this.name = 'NotFoundError';
   this.status = 404;