packager: add transform-class-properties transform

Summary: I found myself a few times wanting that transform, that makes it slightly simpler to have bound method. So I propose we add it. Not a big deal though. Note it also allows static properties with the same syntax, that is handy.

Reviewed By: davidaurelio

Differential Revision: D5051579

fbshipit-source-id: 7ebf7c709bf52a30a525550c1eda1a6a2f7b8e1e

package.json

@@ -140,6 +140,7 @@
     "babel-plugin-external-helpers": "^6.18.0",
     "babel-plugin-syntax-trailing-function-commas": "^6.20.0",
     "babel-plugin-transform-async-to-generator": "6.16.0",
+    "babel-plugin-transform-class-properties": "^6.18.0",
     "babel-plugin-transform-flow-strip-types": "^6.21.0",
     "babel-plugin-transform-object-rest-spread": "^6.20.2",
     "babel-polyfill": "^6.20.0",

packager/babelRegisterOnly.js

@@ -25,6 +25,7 @@ function config(onlyList) {
       'syntax-trailing-function-commas',
       'transform-object-rest-spread',
       'transform-async-to-generator',
+      'transform-class-properties',
     ].map(pluginName => require(`babel-plugin-${pluginName}`)),
     only: _only,
     retainLines: true,

packager/src/node-haste/DependencyGraph/ResolutionRequest.js

@@ -110,15 +110,15 @@ function tryResolveSync<T>(action: () => T, secondaryAction: () => T): T {
 }
 
 class ResolutionRequest<TModule: Moduleish, TPackage: Packageish> {
-  _doesFileExist: (filePath: string) => boolean;
+  _doesFileExist = filePath => this._options.hasteFS.exists(filePath);
   _immediateResolutionCache: {[key: string]: TModule};
   _options: Options<TModule, TPackage>;
-  static emptyModule: string;
+
+  static EMPTY_MODULE: string = require.resolve('./assets/empty-module.js');
 
   constructor(options: Options<TModule, TPackage>) {
     this._options = options;
     this._resetResolutionCache();
-    this._doesFileExist = filePath => this._options.hasteFS.exists(filePath);
   }
 
   _tryResolve<T>(
@@ -465,7 +465,7 @@ class ResolutionRequest<TModule: Moduleish, TPackage: Packageish> {
     );
     if (realModuleName === false) {
       return this._loadAsFile(
-        ResolutionRequest.emptyModule,
+        ResolutionRequest.EMPTY_MODULE,
         fromModule,
         toModuleName,
       );
@@ -485,7 +485,7 @@ class ResolutionRequest<TModule: Moduleish, TPackage: Packageish> {
     // exclude
     if (realModuleName === false) {
       return this._loadAsFile(
-        ResolutionRequest.emptyModule,
+        ResolutionRequest.EMPTY_MODULE,
         fromModule,
         toModuleName,
       );
@@ -814,6 +814,4 @@ function getArrayLowestItem(a: Array<string>): string | void {
   return lowest;
 }
 
-ResolutionRequest.emptyModule = require.resolve('./assets/empty-module.js');
-
 module.exports = ResolutionRequest;

packager/src/node-haste/__tests__/DependencyGraph-test.js

@@ -1819,7 +1819,7 @@ describe('DependencyGraph', function() {
       });
 
       it('should support browser exclude of a package ("' + fieldName + '")', function() {
-        ResolutionRequest.emptyModule = '/root/emptyModule.js';
+        ResolutionRequest.EMPTY_MODULE = '/root/emptyModule.js';
         var root = '/root';
         setMockFileSystem({
           'root': {
@@ -1885,7 +1885,7 @@ describe('DependencyGraph', function() {
       });
 
       it('should support browser exclude of a file ("' + fieldName + '")', function() {
-        ResolutionRequest.emptyModule = '/root/emptyModule.js';
+        ResolutionRequest.EMPTY_MODULE = '/root/emptyModule.js';
 
         var root = '/root';
         setMockFileSystem({