Remove max and min font size from serialization of text attribute

Summary:
Removing two props that are not currently used

They are being set as quiet_NaN  in C++ and this brings problems in the Android side

Reviewed By: shergin

Differential Revision: D13188600

fbshipit-source-id: e8412497a80300cfbc3770b829e9633206aaf427
This commit is contained in:
David Vacca 2018-11-25 17:18:12 -08:00 committed by Facebook Github Bot
parent 5be17c01a1
commit 3be2816aec
2 changed files with 0 additions and 6 deletions

View File

@ -381,8 +381,6 @@ inline folly::dynamic toDynamic(
values("maximumNumberOfLines", paragraphAttributes.maximumNumberOfLines);
values("ellipsizeMode", toString(paragraphAttributes.ellipsizeMode));
values("adjustsFontSizeToFit", paragraphAttributes.adjustsFontSizeToFit);
values("minimumFontSize", paragraphAttributes.minimumFontSize);
values("maximumFontSize", paragraphAttributes.maximumFontSize);
return values;
}

View File

@ -21,8 +21,6 @@ TEST(ParagraphAttributesTest, testToDynamic) {
paragraphAttributes.maximumNumberOfLines = 2;
paragraphAttributes.adjustsFontSizeToFit = false;
paragraphAttributes.ellipsizeMode = EllipsizeMode::Middle;
paragraphAttributes.minimumFontSize = 10;
paragraphAttributes.maximumFontSize = 20;
auto result = toDynamic(paragraphAttributes);
assert(
@ -33,8 +31,6 @@ TEST(ParagraphAttributesTest, testToDynamic) {
paragraphAttributes.adjustsFontSizeToFit);
assert(
result["ellipsizeMode"] == toString(paragraphAttributes.ellipsizeMode));
assert(result["minimumFontSize"] == paragraphAttributes.minimumFontSize);
assert(result["maximumFontSize"] == paragraphAttributes.maximumFontSize);
}
} // namespace react