status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-23 14:48:25 +00:00
Code Issues Projects Releases Wiki Activity

ReactActivity extends AppCompatActivity (#23278)

Browse Source 
Summary:
Google recommends to extend AppCompatActivity. and This PR changes ReactActivity to extend AppCompatActivity

[Android] [Changed] - ReactActivity extends AppCompatActivity
Pull Request resolved: https://github.com/facebook/react-native/pull/23278

Reviewed By: fkgozali

Differential Revision: D13937917

Pulled By: mdvacca

fbshipit-source-id: 4216482b30349b24e3cbf2bdc24d9a890744132f
This commit is contained in:
Dulmandakh 2019-02-05 12:06:31 -08:00 committed by Facebook Github Bot
parent d53dbb0dfb
commit 3b9604feda
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ReactAndroid/src/main/java/com/facebook/react/BUCK
View File

@ -4,8 +4,8 @@ rn_android_library(
name = "react", name = "react",
srcs = glob(["*.java"]), srcs = glob(["*.java"]),
provided_deps = [ provided_deps = [
react_native_dep("third-party/android/support/v7/appcompat-orig:appcompat"),
react_native_dep("third-party/android/support/v4:lib-support-v4"), react_native_dep("third-party/android/support/v4:lib-support-v4"),
react_native_dep("third-party/android/support-annotations:android-support-annotations"),
], ],
visibility = [ visibility = [
"PUBLIC", "PUBLIC",

4
ReactAndroid/src/main/java/com/facebook/react/ReactActivity.java
View File

@ -11,7 +11,7 @@ import javax.annotation.Nullable;
import android.content.Intent; import android.content.Intent;
import android.os.Bundle; import android.os.Bundle;
import android.support.v4.app.FragmentActivity; import android.support.v7.app.AppCompatActivity;
import android.view.KeyEvent; import android.view.KeyEvent;
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler; import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
@ -21,7 +21,7 @@ import com.facebook.react.modules.core.PermissionListener;
/** /**
* Base Activity for React Native applications. * Base Activity for React Native applications.
*/ */
public abstract class ReactActivity extends FragmentActivity public abstract class ReactActivity extends AppCompatActivity
implements DefaultHardwareBackBtnHandler, PermissionAwareActivity { implements DefaultHardwareBackBtnHandler, PermissionAwareActivity {
private final ReactActivityDelegate mDelegate; private final ReactActivityDelegate mDelegate;