status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-23 22:58:19 +00:00
Code Issues Projects Releases Wiki Activity

Fix onPress for TextView containing just RawText

Browse Source 
Summary: This diff enables the onPress event for TextViews that render RawText

Reviewed By: shergin

Differential Revision: D10222183

fbshipit-source-id: 4b6a6ad548286453f7dd3a14a5e4ee453a55b923
This commit is contained in:
David Vacca 2018-10-09 16:30:11 -07:00 committed by Facebook Github Bot
parent 74a00beeb7
commit 397573ffed
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java
View File

@ -143,9 +143,7 @@ public class TextLayoutManager {
new CustomTextTransformSpan(textAttributes.mTextTransform))); new CustomTextTransformSpan(textAttributes.mTextTransform)));
} }
//TODO: add react tag as part of the fragments, react tag is used on Touch events int reactTag = fragment.getInt("reactTag");
int reactTag = 1;
ops.add(new SetSpanOperation(start, end, new ReactTagSpan(reactTag))); ops.add(new SetSpanOperation(start, end, new ReactTagSpan(reactTag)));
} }
} }

9
ReactCommon/fabric/attributedstring/conversions.h
View File

@ -7,14 +7,16 @@
#pragma once #pragma once
#include <fabric/attributedstring/conversions.h>
#include <fabric/attributedstring/primitives.h>
#include <fabric/attributedstring/AttributedString.h> #include <fabric/attributedstring/AttributedString.h>
#include <fabric/attributedstring/ParagraphAttributes.h> #include <fabric/attributedstring/ParagraphAttributes.h>
#include <fabric/attributedstring/TextAttributes.h> #include <fabric/attributedstring/TextAttributes.h>
#include <fabric/attributedstring/conversions.h>
#include <fabric/attributedstring/primitives.h>
#include <fabric/core/conversions.h> #include <fabric/core/conversions.h>
#include <fabric/graphics/Geometry.h> #include <fabric/core/LayoutableShadowNode.h>
#include <fabric/core/ShadowNode.h>
#include <fabric/graphics/conversions.h> #include <fabric/graphics/conversions.h>
#include <fabric/graphics/Geometry.h>
#include <folly/dynamic.h> #include <folly/dynamic.h>
namespace facebook { namespace facebook {
@ -474,6 +476,7 @@ inline folly::dynamic toDynamic(const AttributedString &attributedString) {
for (auto fragment : attributedString.getFragments()) { for (auto fragment : attributedString.getFragments()) {
folly::dynamic dynamicFragment = folly::dynamic::object(); folly::dynamic dynamicFragment = folly::dynamic::object();
dynamicFragment["string"] = fragment.string; dynamicFragment["string"] = fragment.string;
dynamicFragment["reactTag"] = fragment.parentShadowNode->getTag();
dynamicFragment["textAttributes"] = toDynamic(fragment.textAttributes); dynamicFragment["textAttributes"] = toDynamic(fragment.textAttributes);
fragments.push_back(dynamicFragment); fragments.push_back(dynamicFragment);
} }