status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix broken text padding on Nodes 

Summary:
We were always getting LEFT explicitly, and, due to RTL support, we
should be asking for START instead.

Reviewed By: sriramramani

Differential Revision: D3836816
This commit is contained in:
Ahmed El-Helw 2016-09-12 10:20:06 -07:00
parent 3ac0bd632c
commit 3766ec9764
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ReactAndroid/src/main/java/com/facebook/react/flat/FlatNativeViewHierarchyManager.java
View File

@ -12,7 +12,6 @@ package com.facebook.react.flat;
import javax.annotation.Nullable;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import android.util.SparseArray;

2
ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java
View File

@ -175,7 +175,7 @@ import com.facebook.react.uimanager.annotations.ReactProp;
Spacing padding = getPadding();
left += padding.get(Spacing.LEFT);
left += padding.get(Spacing.START);
top += padding.get(Spacing.TOP);
// these are actual right/bottom coordinates where this DrawCommand will draw.