status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add some defensive loggin in Android touch handling 

Reviewed By: andreicoman11

Differential Revision: D3292369

fbshipit-source-id: 43315f7d8e81f1a0ec238c08c3cb689e6648fd0b
This commit is contained in:
Dave Miller 2016-05-12 10:00:06 -07:00 committed by Facebook Github Bot 4
parent f2c1868b56
commit 31c8b3bd61
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ReactAndroid/src/main/java/com/facebook/react/uimanager/events/TouchEventCoalescingKeyHelper.java
View File

@ -81,6 +81,10 @@ public class TouchEventCoalescingKeyHelper {
* Stops tracking a new coalescing key corresponding to the gesture with this down time. * Stops tracking a new coalescing key corresponding to the gesture with this down time.
*/ */
public static void removeCoalescingKey(long downTime) { public static void removeCoalescingKey(long downTime) {
int currentValue = sDownTimeToCoalescingKey.get((int) downTime, -1);
if (currentValue == -1) {
throw new RuntimeException("Tried to remove non-existent cookie");
}
sDownTimeToCoalescingKey.delete((int) downTime); sDownTimeToCoalescingKey.delete((int) downTime);
} }
} }

2
ReactAndroid/src/test/java/com/facebook/react/RootViewTest.java
View File

@ -162,7 +162,7 @@ public class RootViewTest {
ArgumentCaptor.forClass(JavaOnlyArray.class); ArgumentCaptor.forClass(JavaOnlyArray.class);
rootView.onTouchEvent( rootView.onTouchEvent(
MotionEvent.obtain(50, ts, MotionEvent.ACTION_UP, 0, 0, 0)); MotionEvent.obtain(100, ts, MotionEvent.ACTION_UP, 0, 0, 0));
verify(eventDispatcher).dispatchEvent(upEventCaptor.capture()); verify(eventDispatcher).dispatchEvent(upEventCaptor.capture());
verifyNoMoreInteractions(eventDispatcher); verifyNoMoreInteractions(eventDispatcher);