From 3061606fe65062b93704155eb7c7e15c70280d16 Mon Sep 17 00:00:00 2001 From: Ahmed El-Helw Date: Wed, 7 Sep 2016 14:27:01 -0700 Subject: [PATCH] Fix TextInput padding on Nodes Summary: Fix TextInput padding on Nodes. We used to not call super and used to manually do the setting of padding. This stops us from running the same logic that non-Nodes runs (we bypassed it), so this fixes it. Reviewed By: astreet Differential Revision: D3825227 --- .../main/java/com/facebook/react/flat/RCTTextInput.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java index ba002a0da..63582ca85 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTTextInput.java @@ -18,7 +18,6 @@ import android.util.TypedValue; import android.view.ViewGroup; import android.widget.EditText; -import com.facebook.csslayout.CSSDirection; import com.facebook.csslayout.CSSMeasureMode; import com.facebook.csslayout.CSSNodeAPI; import com.facebook.csslayout.MeasureOutput; @@ -154,10 +153,9 @@ public class RCTTextInput extends RCTVirtualText implements AndroidView, CSSNode @Override public void setPadding(int spacingType, float padding) { - if (getPadding().set(spacingType, padding)) { - mPaddingChanged = true; - dirty(); - } + super.setPadding(spacingType, padding); + mPaddingChanged = true; + dirty(); } @Override