status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-03-03 10:50:35 +00:00
Code Issues Projects Releases Wiki Activity

[Flow] Update flowconfig's version req to 0.13.1, fix Movies example typechecking

Browse Source 
This should fix tests.

Test Plan: Run Travis CI tests. Also run the movies app and verify that there are no invariant violations.
This commit is contained in:
James Ide 2015-06-30 13:45:28 -07:00
parent 951b5f9517
commit 301c01260d
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.flowconfig
View File

@ -45,4 +45,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(1[0-2]\\|[0-9]\\).[0-9
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
[version] [version]
0.12.0 0.13.1

7
Examples/Movies/SearchScreen.js
View File

@ -26,6 +26,8 @@ var {
} = React; } = React;
var TimerMixin = require('react-timer-mixin'); var TimerMixin = require('react-timer-mixin');
var invariant = require('invariant');
var MovieCell = require('./MovieCell'); var MovieCell = require('./MovieCell');
var MovieScreen = require('./MovieScreen'); var MovieScreen = require('./MovieScreen');
@ -73,18 +75,16 @@ var SearchScreen = React.createClass({
this.searchMovies(''); this.searchMovies('');
}, },
_urlForQueryAndPage: function(query: string, pageNumber: ?number): string { _urlForQueryAndPage: function(query: string, pageNumber: number): string {
var apiKey = API_KEYS[this.state.queryNumber % API_KEYS.length]; var apiKey = API_KEYS[this.state.queryNumber % API_KEYS.length];
if (query) { if (query) {
return ( return (
// $FlowFixMe(>=0.13.0) - pageNumber may be null or undefined
API_URL + 'movies.json?apikey=' + apiKey + '&q=' + API_URL + 'movies.json?apikey=' + apiKey + '&q=' +
encodeURIComponent(query) + '&page_limit=20&page=' + pageNumber encodeURIComponent(query) + '&page_limit=20&page=' + pageNumber
); );
} else { } else {
// With no query, load latest movies // With no query, load latest movies
return ( return (
// $FlowFixMe(>=0.13.0) - pageNumber may be null or undefined
API_URL + 'lists/movies/in_theaters.json?apikey=' + apiKey + API_URL + 'lists/movies/in_theaters.json?apikey=' + apiKey +
'&page_limit=20&page=' + pageNumber '&page_limit=20&page=' + pageNumber
); );
@ -176,6 +176,7 @@ var SearchScreen = React.createClass({
}); });
var page = resultsCache.nextPageNumberForQuery[query]; var page = resultsCache.nextPageNumberForQuery[query];
invariant(page != null, 'Next page number for "%s" is missing', query);
fetch(this._urlForQueryAndPage(query, page)) fetch(this._urlForQueryAndPage(query, page))
.then((response) => response.json()) .then((response) => response.json())
.catch((error) => { .catch((error) => {

2
Examples/SampleApp/_flowconfig
View File

@ -33,4 +33,4 @@ node_modules/react-native/Libraries/react-native/react-native-interface.js
module.system=haste module.system=haste
[version] [version]
0.12.0 0.13.1