status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove components out of Bindings 

Summary: This diff removes the components dependencies out of the Fabric/jsi/jni project

Reviewed By: shergin

Differential Revision: D13734001

fbshipit-source-id: 65182bfa5ee9fcd526a9afc40bd9fd6f0b86c5a5
This commit is contained in:
David Vacca 2019-01-28 19:41:29 -08:00 committed by Facebook Github Bot
parent cf0c37b08b
commit 2b356590f8
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/BUCK
View File

@ -28,14 +28,8 @@ rn_xplat_cxx_library(
deps = [
react_native_xplat_target("config:config"),
react_native_xplat_target("fabric/uimanager:uimanager"),
react_native_xplat_target("fabric/components/activityindicator:activityindicator"),
react_native_xplat_target("fabric/components/scrollview:scrollview"),
react_native_xplat_target("fabric/components/image:image"),
react_native_xplat_target("fabric/components/text:text"),
react_native_target("jni/react/jni:jni"),
"xplat//ReactNative/fabric/components/ReactPerformanceLogger:ReactPerformanceLogger",
"xplat//ReactNative/fabric/components/ShimmeringView:ShimmeringView",
"xplat//ReactNative/fabric/components/TemplateView:TemplateView",
"xplat//fbsystrace:fbsystrace",
"xplat//folly:molly",
"xplat//jsi:JSIDynamic",

1
ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/Binding.cpp
View File

@ -120,6 +120,7 @@ void Binding::uninstallFabricUIManager() {
javaUIManager_ = nullptr;
}
//TODO: this method will be removed when binding for components are code-gen
local_ref<JString> getPlatformComponentName(const ShadowView &shadowView) {
local_ref<JString> componentName;
auto newViewProps = std::dynamic_pointer_cast<const ScrollViewProps>(shadowView.props);