diff --git a/ReactCommon/jsinspector/InspectorInterfaces.cpp b/ReactCommon/jsinspector/InspectorInterfaces.cpp index 212928759..f1fa2ed57 100644 --- a/ReactCommon/jsinspector/InspectorInterfaces.cpp +++ b/ReactCommon/jsinspector/InspectorInterfaces.cpp @@ -18,9 +18,10 @@ namespace react { // pure destructors in C++ are odd. You would think they don't want an // implementation, but in fact the linker requires one. Define them to be // empty so that people don't count on them for any particular behaviour. -IDestructible::~IDestructible() { } -ILocalConnection::~ILocalConnection() { } -IRemoteConnection::~IRemoteConnection() { } +IDestructible::~IDestructible() {} +ILocalConnection::~ILocalConnection() {} +IRemoteConnection::~IRemoteConnection() {} +IInspector::~IInspector() {} namespace { diff --git a/ReactCommon/jsinspector/InspectorInterfaces.h b/ReactCommon/jsinspector/InspectorInterfaces.h index d137f5a58..0222501f3 100644 --- a/ReactCommon/jsinspector/InspectorInterfaces.h +++ b/ReactCommon/jsinspector/InspectorInterfaces.h @@ -44,11 +44,13 @@ class ILocalConnection : public IDestructible { }; /// IInspector tracks debuggable JavaScript targets (pages). -class IInspector { +class IInspector : public IDestructible { public: using ConnectFunc = std::function( std::unique_ptr)>; + virtual ~IInspector() = 0; + /// addPage is called by the VM to add a page to the list of debuggable pages. virtual int addPage(const std::string& title, ConnectFunc connectFunc) = 0;