status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-22 14:18:23 +00:00
Code Issues Projects Releases Wiki Activity

Avoid serializing UndefinedColor when rendering texts

Browse Source 
Summary: This diff avoids the serialization of color that are set as: "UndefinedColor". This allows the text rendering system to set the default color in the native side

Reviewed By: shergin

Differential Revision: D10275834

fbshipit-source-id: b81c7a5995bef65e04a246d99f44ff10cb20f548
This commit is contained in:
David Vacca 2018-10-09 16:30:22 -07:00 committed by Facebook Github Bot
parent 397573ffed
commit 28d80e4717
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ReactCommon/fabric/attributedstring/conversions.h
View File

@ -387,7 +387,9 @@ inline folly::dynamic toDynamic(
inline folly::dynamic toDynamic(const TextAttributes &textAttributes) {
auto _textAttributes = folly::dynamic::object();
_textAttributes("foregroundColor", toDynamic(textAttributes.foregroundColor));
if (textAttributes.foregroundColor) {
_textAttributes("foregroundColor", toDynamic(textAttributes.foregroundColor));
}
if (textAttributes.backgroundColor) {
_textAttributes(
"backgroundColor", toDynamic(textAttributes.backgroundColor));