From 27348f0f074a79058dbf2c0b87f90a76f157833b Mon Sep 17 00:00:00 2001 From: Ram N Date: Thu, 6 Sep 2018 23:48:18 -0700 Subject: [PATCH] Remove getEagerNativeModules() Summary: An experiment was added to A/B test eager modules. Removing this experiment, as the next diff on this stack has a different way to add eager modules per route. Reviewed By: achen1 Differential Revision: D9685803 fbshipit-source-id: ca6c91ca377b6dfaf5accda1e1f6bbfe17b1d616 --- .../com/facebook/react/TurboReactPackage.java | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java b/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java index 221abf474..a55e473af 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java +++ b/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java @@ -25,17 +25,6 @@ public abstract class TurboReactPackage implements ReactPackage { "In case of TurboModules, createNativeModules is not supported. NativeModuleRegistry should instead use getModuleList or getModule method"); } - /** - * This is only a temporary method to test the impact of initializing some modules eagerly. This - * will deleted whenn - * qe_react_native_startup_module_optimization.eager_init_current_viewer_native_module is removed - * - * @return - */ - protected List getEagerNativeModules() { - return Collections.emptyList(); - } - /** * The API needed for TurboModules. Given a module name, it returns an instance of {@link * NativeModule} for the name @@ -60,7 +49,6 @@ public abstract class TurboReactPackage implements ReactPackage { final Set> entrySet = getReactModuleInfoProvider().getReactModuleInfos().entrySet(); final Iterator> entrySetIterator = entrySet.iterator(); - final List eagerNativeModules = getEagerNativeModules(); return new Iterable() { @NonNull @Override @@ -77,12 +65,7 @@ public abstract class TurboReactPackage implements ReactPackage { Map.Entry entry = entrySetIterator.next(); String name = entry.getKey(); ReactModuleInfo reactModuleInfo = entry.getValue(); - if (eagerNativeModules.contains(name)) { - return new ModuleHolder(getModule(name, reactContext)); - } else { - return new ModuleHolder( - reactModuleInfo, new ModuleHolderProvider(name, reactContext)); - } + return new ModuleHolder(reactModuleInfo, new ModuleHolderProvider(name, reactContext)); } @Override