status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed unit tests 

Reviewed By: bestander

Differential Revision: D3399766

fbshipit-source-id: ebc72a9d02ff812eccae13efc1492d2fec3f95c3
This commit is contained in:
Nick Lockwood 2016-06-07 12:33:58 -07:00 committed by Facebook Github Bot 7
parent 39eca05b91
commit 26a5b033f8
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Examples/UIExplorer/UIExplorerIntegrationTests/RCTUIManagerScenarioTests.m
View File

@ -73,6 +73,8 @@
removeAtIndices:nil removeAtIndices:nil
registry:(NSMutableDictionary<NSNumber *, id<RCTComponent>> *)_uiManager.viewRegistry]; registry:(NSMutableDictionary<NSNumber *, id<RCTComponent>> *)_uiManager.viewRegistry];
[_uiManager.viewRegistry[@20] didUpdateReactSubviews];
XCTAssertTrue([[containerView reactSubviews] count] == 5, XCTAssertTrue([[containerView reactSubviews] count] == 5,
@"Expect to have 5 react subviews after calling manage children \ @"Expect to have 5 react subviews after calling manage children \
with 5 tags to add, instead have %lu", (unsigned long)[[containerView reactSubviews] count]); with 5 tags to add, instead have %lu", (unsigned long)[[containerView reactSubviews] count]);
@ -107,6 +109,8 @@
removeAtIndices:removeAtIndices removeAtIndices:removeAtIndices
registry:(NSMutableDictionary<NSNumber *, id<RCTComponent>> *)_uiManager.viewRegistry]; registry:(NSMutableDictionary<NSNumber *, id<RCTComponent>> *)_uiManager.viewRegistry];
[_uiManager.viewRegistry[@20] didUpdateReactSubviews];
XCTAssertEqual(containerView.reactSubviews.count, (NSUInteger)13, XCTAssertEqual(containerView.reactSubviews.count, (NSUInteger)13,
@"Expect to have 13 react subviews after calling manage children\ @"Expect to have 13 react subviews after calling manage children\
with 5 tags to remove and 18 prior children, instead have %zd", with 5 tags to remove and 18 prior children, instead have %zd",

BIN
Examples/UIExplorer/UIExplorerIntegrationTests/ReferenceImages/Examples-UIExplorer-UIExplorerApp.ios/testViewExample_1@2x.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 153 KiB

After

Width:  |  Height:  |  Size: 111 KiB

6
Examples/UIExplorer/UIExplorerUnitTests/RCTUIManagerTests.m
View File

@ -73,6 +73,8 @@
removeAtIndices:nil removeAtIndices:nil
registry:_uiManager.viewRegistry]; registry:_uiManager.viewRegistry];
[containerView didUpdateReactSubviews];
XCTAssertTrue([[containerView reactSubviews] count] == 5, XCTAssertTrue([[containerView reactSubviews] count] == 5,
@"Expect to have 5 react subviews after calling manage children \ @"Expect to have 5 react subviews after calling manage children \
with 5 tags to add, instead have %lu", (unsigned long)[[containerView reactSubviews] count]); with 5 tags to add, instead have %lu", (unsigned long)[[containerView reactSubviews] count]);
@ -107,6 +109,8 @@
removeAtIndices:removeAtIndices removeAtIndices:removeAtIndices
registry:_uiManager.viewRegistry]; registry:_uiManager.viewRegistry];
[containerView didUpdateReactSubviews];
XCTAssertEqual(containerView.reactSubviews.count, (NSUInteger)13, XCTAssertEqual(containerView.reactSubviews.count, (NSUInteger)13,
@"Expect to have 13 react subviews after calling manage children\ @"Expect to have 13 react subviews after calling manage children\
with 5 tags to remove and 18 prior children, instead have %zd", with 5 tags to remove and 18 prior children, instead have %zd",
@ -166,6 +170,8 @@
removeAtIndices:removeAtIndices removeAtIndices:removeAtIndices
registry:_uiManager.viewRegistry]; registry:_uiManager.viewRegistry];
[containerView didUpdateReactSubviews];
XCTAssertTrue([[containerView reactSubviews] count] == 8, XCTAssertTrue([[containerView reactSubviews] count] == 8,
@"Expect to have 8 react subviews after calling manage children,\ @"Expect to have 8 react subviews after calling manage children,\
instead have the following subviews %@", [containerView reactSubviews]); instead have the following subviews %@", [containerView reactSubviews]);